Avoid to access Java DeprecatedAlias value other than Ruby's one#16506
Merged
andsel merged 3 commits intoelastic:mainfrom Oct 4, 2024
Merged
Avoid to access Java DeprecatedAlias value other than Ruby's one#16506andsel merged 3 commits intoelastic:mainfrom
andsel merged 3 commits intoelastic:mainfrom
Conversation
…not just the Ruby one
|
💚 Build Succeeded
History
cc @andsel |
Member
Author
|
@logstashmachine backport 8.x |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
) Update Settings to_hash method to also skip Java DeprecatedAlias and not just the Ruby one. With PR #15679 was introduced org.logstash.settings.DeprecatedAlias which mirrors the behaviour of Ruby class Setting::DeprecatedAlias. The equality check at Logstash::Settings, as descibed in #16505 (comment), is implemented comparing the maps. The conversion of Settings to the corresponding maps filtered out the Ruby implementation of DeprecatedAlias but not the Java one. This PR adds also the Java one to the list of filter. (cherry picked from commit 5d4825f)
Merged
2 tasks
andsel
added a commit
that referenced
this pull request
Oct 11, 2024
… other than Ruby's one Update Settings to_hash method to also skip Java DeprecatedAlias and not just the Ruby one. With PR #15679 was introduced org.logstash.settings.DeprecatedAlias which mirrors the behaviour of Ruby class Setting::DeprecatedAlias. The equality check at Logstash::Settings, as descibed in #16505 (comment), is implemented comparing the maps. The conversion of Settings to the corresponding maps filtered out the Ruby implementation of DeprecatedAlias but not the Java one. This PR adds also the Java one to the list of filter. (cherry picked from commit 5d4825f) Co-authored-by: Andrea Selva <selva.andre@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Update Settings to_hash method to also skip Java DeprecatedAlias and not just the Ruby one.
With PR #15679 was introduced
org.logstash.settings.DeprecatedAliaswhich mirrors the behaviour of Ruby classSetting::DeprecatedAlias. The equality check atLogstash::Settings, as descibed in ##16505 (comment), is implemented comparing the maps.The conversion of
Settingsto the corresponding maps filtered out the Ruby implementation of DeprecatedAlias but not the Java one.This PR adds also the Java one to the list of filter.
Why is it important/What is the impact to the user?
When the user run Logstash using
pipelines.ymland enable autoreloading, avoid to continuously log a warn message that's unrelated to the context of configuration change checking.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
How to test this PR locally
Follow the steps defined in issue #16505
Related issues