Skip to content

Doc: Update upgrade info for 8.0 in main#13705

Merged
karenzone merged 4 commits intoelastic:mainfrom
karenzone:upgrade
Feb 9, 2022
Merged

Doc: Update upgrade info for 8.0 in main#13705
karenzone merged 4 commits intoelastic:mainfrom
karenzone:upgrade

Conversation

@karenzone
Copy link
Copy Markdown
Contributor

@karenzone karenzone commented Feb 3, 2022

** <<field-ref-strict,Field parser is more strict and how that affects processing>>
** <<beats-ecs,Beats conforms to the Elastic Common Schema (ECS) and how that impacts {ls}>>
** <<bc-ecs-compatibility,Elastic Common Schema (ECS) compatibility on by default>>
** Secure communication with Elasticsearch
Copy link
Copy Markdown
Contributor Author

@karenzone karenzone Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToDo: Add link after security content has been merged (#13693)

[float]
[[upgrading-logstash-pqs-6.3]]
==== Upgrading from version 6.3 (and later) with Persistent Queues Enabled
=== Upgrading with the persistent queue enabled
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed a lot of PQ upgrade content specific to pre-6.3. I left a smaller chunk of content for upgrading PQs. Let's decide if this makes sense or should be removed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to remove, because in 7.x series the PQ format didn't change so there isn't any path forward in "upgrading" the PQ. If a user has an older version he has however to move 6.x -> 7.x -> 8 so reading the upgrade path of previous major versions he is covered.

Copy link
Copy Markdown
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of notes.

Waiting for https://github.com/elastic/logstash/pull/13705/files#r799043866 to be completed.

Please , request again a review after those, so that I can approve


[[upgrading-using-direct-download]]
=== Upgrading Using a Direct Download
=== Upgrading using a direct download
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note, the PR #13684 touches the same list, in case we want to have a unique PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged before this PR


[float]
[discrete]
[[upgrade-to-6.8-rec]]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we change also the title section from [[upgrade-to-6.8-rec]] to something like [[upgrade-to-latest-previous-major]] ?

[float]
[[upgrading-logstash-pqs-6.3]]
==== Upgrading from version 6.3 (and later) with Persistent Queues Enabled
=== Upgrading with the persistent queue enabled
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to remove, because in 7.x series the PQ format didn't change so there isn't any path forward in "upgrading" the PQ. If a user has an older version he has however to move 6.x -> 7.x -> 8 so reading the upgrade path of previous major versions he is covered.

and have the persistent queue enabled, we strongly recommend that you drain or
delete the persistent queue before you upgrade. See <<upgrading-logstash-pqs>>
delete the persistent queue before you upgrade. See <<draining-pqs>>
for information and instructions.
Copy link
Copy Markdown
Contributor Author

@karenzone karenzone Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this info is in Breaking Changes, not Upgrade. If we decide to remove it post-release, we can do that. For now, I changed the link to avoid breaking the doc build by pointing to content that has been removed.

@karenzone karenzone marked this pull request as ready for review February 9, 2022 15:52
Copy link
Copy Markdown
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenzone karenzone changed the title Doc: Update upgrade info for 8.0 Doc: Update upgrade info for 8.0 in main Feb 9, 2022
@karenzone karenzone merged commit 04d99b9 into elastic:main Feb 9, 2022
@karenzone karenzone deleted the upgrade branch February 9, 2022 16:46
karenzone added a commit to karenzone/logstash that referenced this pull request Feb 9, 2022
karenzone added a commit to karenzone/logstash that referenced this pull request Feb 9, 2022
karenzone added a commit that referenced this pull request Feb 9, 2022
karenzone added a commit that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants