Grep filter for numerical fields#129
Merged
jordansissel merged 1 commit intoelastic:masterfrom Mar 29, 2012
Merged
Conversation
Contributor
There was a problem hiding this comment.
I will merge and make the following change:
>> Fixnum.ancestors
=> [Fixnum, Integer, Numeric, Comparable, Object, Kernel, BasicObject]
I think this should check: if value.is_a?(Numeric)
jordansissel
added a commit
that referenced
this pull request
Mar 29, 2012
Grep filter for numerical fields
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've been running into problems when trying to filter on numerical event fields, such as severity and facility for syslog events. This causes an exception when the regexp is applied to a Fixnum.
I've attached a simple patch to convert numerical fields to strings before matching - not sure if this is useful or not.
Cheers,
Phil