Skip to content

[Fleet] Remove beats management plugin#99789

Merged
afgomez merged 7 commits intoelastic:masterfrom
afgomez:90614-remove-beats-central-management
May 27, 2021
Merged

[Fleet] Remove beats management plugin#99789
afgomez merged 7 commits intoelastic:masterfrom
afgomez:90614-remove-beats-central-management

Conversation

@afgomez
Copy link
Copy Markdown
Contributor

@afgomez afgomez commented May 11, 2021 •
edited by tylersmalley
Loading

Summary

Closes #90614
Closes #95855

Remove the deprecated beats management plugin and its references.

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list

For maintainers

@afgomez afgomez added Feature:Fleet Fleet team's agent central management project release_note:deprecation Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0 labels May 11, 2021
@afgomez afgomez force-pushed the 90614-remove-beats-central-management branch 4 times, most recently from 0b7d2b7 to 3ec63d5 Compare May 12, 2021 13:43
This was referenced May 17, 2021
Merged
Closed
@afgomez afgomez force-pushed the 90614-remove-beats-central-management branch from 3ec63d5 to 62eadb2 Compare May 25, 2021 13:57
@afgomez afgomez marked this pull request as ready for review May 25, 2021 13:57
@afgomez afgomez requested a review from a team as a code owner May 25, 2021 13:57
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 25, 2021

Pinging @elastic/fleet (Feature:Fleet)

@afgomez
Copy link
Copy Markdown
Contributor Author

afgomez commented May 25, 2021

I'm not sure how/if we need to update something in the documentation and/or cloud. Please @elastic/fleet let me know how to proceed.

tylersmalley
tylersmalley approved these changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from ops perspective.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 25, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
beatsManagement 244 - -244

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
beatsManagement 2 - -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
beatsManagement 503.9KB - -503.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
beatsManagement 104.3KB - -104.3KB
Unknown metric groups

API count

id before after diff
beatsManagement 2 - -2

async chunk count

id before after diff
beatsManagement 2 - -2

References to deprecated APIs

id before after diff
beatsManagement 2 - -2
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -344

History

  • 💚 Build #125556 succeeded 3ec63d51fdd6ecb95e539fc12cc166f62e29f8d5
  • 💚 Build #125526 succeeded 0b7d2b78ffa1f83be1de4bffa5c9b3ca089007af
  • 💚 Build #125516 succeeded 7e28cc17dbd980698bc0f37caa530c5462bc422f
  • 💔 Build #125501 failed ddcbb6eb24ed692a0981265402ae40c6dbc246eb
  • 💔 Build #125308 failed 14e6e7d478b659ad18dcc0c4bb3c6e65500d755d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jen-huang jen-huang requested a review from a team May 25, 2021 16:27
jen-huang
jen-huang approved these changes May 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As we discussed, could you create an issue in https://github.com/elastic/observability-docs to document this plugin deprecation? And AFAIK there shouldn't be any impact on Cloud wrt to configuration, but still good to double check.

@afgomez afgomez merged commit 83e5b6c into elastic:master May 27, 2021
@afgomez afgomez deleted the 90614-remove-beats-central-management branch May 27, 2021 09:30
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 31, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 99789 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 31, 2021
@afgomez afgomez mentioned this pull request May 31, 2021
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request May 31, 2021
[Fleet] Remove beats management plugin (elastic#99789)
0e988c5 
# Conflicts:
#	.github/CODEOWNERS
#	api_docs/data.json
#	api_docs/data_index_patterns.json
#	api_docs/deprecations.mdx
#	api_docs/security.json
#	api_docs/spaces.json
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 31, 2021
afgomez pushed a commit that referenced this pull request May 31, 2021
[Fleet] Remove beats management plugin (#99789) (#101010)
8a62b29 
# Conflicts:
#	.github/CODEOWNERS
#	api_docs/data.json
#	api_docs/data_index_patterns.json
#	api_docs/deprecations.mdx
#	api_docs/security.json
#	api_docs/spaces.json
This was referenced Aug 11, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@jbudz jbudz jbudz approved these changes

+1 more reviewer

@jen-huang jen-huang jen-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@afgomez afgomez

Labels

backported Feature:Fleet Fleet team's agent central management project release_note:deprecation Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[beatsManagement] Reduce page load bundle to under 100kB Remove Beats Central Management from Kibana

7 participants

@afgomez @elasticmachine @kibanamachine @tylersmalley @jen-huang @jbudz @spalger