[Maps] use deep equals for mapbox filter expression equals check#99673
Merged
nreese merged 2 commits intoelastic:masterfrom May 11, 2021
Merged
[Maps] use deep equals for mapbox filter expression equals check#99673nreese merged 2 commits intoelastic:masterfrom
nreese merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
approved these changes
May 11, 2021
Contributor
thomasneirynck
left a comment
There was a problem hiding this comment.
thx discuss offline, this really helps readability. it will also help with client-side masking for timeslider when that gets added.
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 11, 2021
…stic#99673) * [Maps] use deep equals for mapbox filter expression equals check * cleanup
nreese
added a commit
that referenced
this pull request
May 11, 2021
) (#99803) * [Maps] use deep equals for mapbox filter expression equals check * cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53246
This PR isolates the mapbox filter expression refactor from closed #96791.