Skip to content

[Exploratory View] Fixed brushing/scrubbing on time series charts#98623

Merged
shahzad31 merged 6 commits intoelastic:masterfrom
shahzad31:fix-exp-view-scrubbing
Apr 29, 2021
Merged

[Exploratory View] Fixed brushing/scrubbing on time series charts#98623
shahzad31 merged 6 commits intoelastic:masterfrom
shahzad31:fix-exp-view-scrubbing

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 commented Apr 28, 2021 •
edited
Loading

Summary

Fixes first and second task from #98602

I didn't find an option to disable Brusing in lens component, so i implemented it for time series charts and where user does brushing on a chart, where it doesn't make sense, for example on a distribution chart, there it will display user a toast if user tries Brushing.

Message copy can be improved, feedback needed.

Also fixed popover toggle state on add filter button

image

@shahzad31 shahzad31 marked this pull request as ready for review April 28, 2021 14:40
@shahzad31 shahzad31 changed the title [Exploratory View]fixed brushing/scrubbing on time series charts [Exploratory View] Fixed brushing/scrubbing on time series charts Apr 28, 2021
@shahzad31 shahzad31 self-assigned this Apr 28, 2021
@shahzad31 shahzad31 added v7.13.0 v7.14.0 release_note:skip Skip the PR/issue when compiling release notes labels Apr 28, 2021
@shahzad31 shahzad31 mentioned this pull request Apr 28, 2021
Closed
4 tasks
formgeist
formgeist approved these changes Apr 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding brushing for time-series works for me - and displaying the message is better than the user not knowing why it's not available for any other x-axis. Made a small comment on the toast.

@shahzad31 @formgeist
Update x-pack/plugins/observability/public/components/shared/explorat…
67de9bf 
…ory_view/exploratory_view.tsx

Co-authored-by: Casper Hübertz <casper@formgeist.com>
@katrin-freihofner
Copy link
Copy Markdown

katrin-freihofner commented Apr 28, 2021

I just found out about this case where the Lens app is not available. Any chance we could link to a place where the user can enable it?

Screenshot 2021-04-28 at 18 52 25

@shahzad31
Copy link
Copy Markdown
Contributor Author

shahzad31 commented Apr 29, 2021

@formgeist also pushed the change to make Metric and chart type full width , also fixed the issue you raised in the same issue Selecting an application makes another option disappear

image

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 29, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 521.1KB 521.5KB +372.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

@formgeist
Copy link
Copy Markdown
Contributor

formgeist commented Apr 29, 2021

@shahzad31 Thanks for fixing the filter popover as well 👍

@shahzad31 shahzad31 added auto-backport Deprecated - use backport:version if exact versions are needed Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Apr 29, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 29, 2021

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 merged commit 8ac4892 into elastic:master Apr 29, 2021
@shahzad31 shahzad31 deleted the fix-exp-view-scrubbing branch April 29, 2021 12:14
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 29, 2021
@shahzad31 @formgeist @kibanamachine
[Exploratory View] Fixed brushing/scrubbing on time series charts (el…
0afb907 
…astic#98623)

Co-authored-by: Casper Hübertz <casper@formgeist.com>
@kibanamachine kibanamachine mentioned this pull request Apr 29, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 29, 2021
@shahzad31 @formgeist @kibanamachine
[Exploratory View] Fixed brushing/scrubbing on time series charts (el…
b59a19e 
…astic#98623)

Co-authored-by: Casper Hübertz <casper@formgeist.com>
@kibanamachine kibanamachine mentioned this pull request Apr 29, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 29, 2021

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 29, 2021
@kibanamachine @shahzad31 @formgeist
[Exploratory View] Fixed brushing/scrubbing on time series charts (#9…
cef916a 
…8623) (#98736)

Co-authored-by: Casper Hübertz <casper@formgeist.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Co-authored-by: Casper Hübertz <casper@formgeist.com>
kibanamachine added a commit that referenced this pull request Apr 29, 2021
@kibanamachine @shahzad31 @formgeist
[Exploratory View] Fixed brushing/scrubbing on time series charts (#9…
eef5e60 
…8623) (#98735)

Co-authored-by: Casper Hübertz <casper@formgeist.com>

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
Co-authored-by: Casper Hübertz <casper@formgeist.com>
@justinkambic justinkambic mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@formgeist formgeist formgeist approved these changes

@dominiqueclarke dominiqueclarke Awaiting requested review from dominiqueclarke

Assignees

@shahzad31 shahzad31

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.0 v7.14.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shahzad31 @katrin-freihofner @kibanamachine @formgeist @elasticmachine