Skip to content

[ML] Improve check for runtime fields in datafeed query#98289

Merged
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:improve-check-for-runtime-fields-in-datafeed-query
Apr 26, 2021
Merged

[ML] Improve check for runtime fields in datafeed query#98289
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:improve-check-for-runtime-fields-in-datafeed-query

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

Fixes where a job created from a saved search which uses a runtime field with a wildcard (e.g. airline_rt: a*) removes the runtime field from the runtime_mappings when it isn't used as an influencer or partitioning field.

Related to #77462

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.14.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 26, 2021
@jgowdyelastic jgowdyelastic self-assigned this Apr 26, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 26, 2021 13:21
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895
Copy link
Copy Markdown
Member

qn895 commented Apr 26, 2021

LGTM 🎉

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +38.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 26, 2021
)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
kibanamachine added a commit that referenced this pull request Apr 26, 2021
)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
@peteharverson peteharverson mentioned this pull request Apr 27, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.13.0 v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants