Skip flaky monitoring/*_mb tests by brianseeders · Pull Request #98238 · elastic/kibana

brianseeders · 2021-04-24T00:52:01Z

Various tests are failing very often after #96205 was merged.

jasonrhodes · 2021-04-24T01:00:15Z

Looks like it's just the files with an _mb suffix that are failing, which is good because that means it's just new functionality that is being flaky and the current behavior is still stable.

Can we just comment out the _mb files (all of them, not just the elasticsearch ones) for now? I'll investigate first thing next week.

jasonrhodes

Commenting out all _mb tests for now is ok with me. I'll have a ticket up later that links to this one so we can fix those and re-enable them next week.

elasticmachine · 2021-04-24T01:08:08Z

Pinging @elastic/kibana-operations (Team:Operations)

kibanamachine · 2021-04-24T02:09:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 149170c
Storybooks Preview
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Jest Unit Tests

Test Failures

Kibana Pipeline / jest / Jest Tests.src/plugins/expressions/common/execution.Execution expression execution result is undefined until execution completes

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/98102

Stack Trace

Error: expect(received).toBe(expected) // Object.is equality

Expected: undefined
Received: null
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/expressions/common/execution/execution.test.ts:370:44)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2021-04-26T18:06:04Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

These tests were disabled temporarily in elastic#98238 because of intermittent failures in master.

elasticmachine · 2021-04-26T18:21:17Z

Pinging @elastic/stack-monitoring (Team:Monitoring)

kibanamachine · 2021-04-27T18:29:25Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98238 or prevent reminders by adding the backport:skip label.

We did this for master but now need to do it for this backport as well, see elastic#98238 for more info

…*` indices (#96205) (#98672) * [Monitoring] Ensure Stack Monitoring UI works with `metricbeat-*` indices (#96205) * WIP * WIP * Remove unnecessary fields * Work on node detail page * Cluster overview looking good * Index page * Fix types * ML jobs * CCR * CCR * We just need total here * Standalone cluster fix * Re-enable logstash * FIx jest test * Fix tests * Fix tests * Fix unused import * Add new MB-based archives * Add actual archives * Fix types * Add this file back in * Fix tests and add more * Update whitelist * Renames * Renames * Only do ccs if enabled * Updates * Comment out * More tests passing * Another passing test * More passing, yay * Forgot to add the actual tests, wow * CCR * Fix CI issues * Missed a field here * Kibana tests passing * Fix type issues * Fix type * Fix types * Good chunk of logstash work * Fix types * Fix jest test * Fix issue with get usage in logstash code * Fix small bug here * Update archives with proper mappings * Handle both legacy and mb fields properly * Fixes * Fix jest test * Fix issue * Getting setup tests in a better state * Only beats is failing now, which is good * Progress on cluster listing * Functional tests passing! * More progress on cluster tests * More cluster work * Fix test * Last recovery working * Fix types * Fix tests * More tweaks * Fix snapshot * Use stats instead of kibana_stats * Use node and node_stats for logstash * Beats tests passing * APM tests passing * API tests passing! * Fix types * Fix tests * Renames beats-with-restarted-instance archive dirs Kebab case is disallowed for all newly added files. * Renames logstash-pipeline dirs Kebab case disallowed for all new files * Renames multi-basic dirs Kebab case disallowed for all new files * Renames singlecluster-* dirs Kebab case disallowed for all new files * Fixes inaccurate path change for archive setup * Reverts changes to rebuild_all script Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/monitoring/server/lib/apm/_apm_stats.js # x-pack/test/api_integration/apis/monitoring/apm/fixtures/cluster.json * Fix merge conflict error, 0 vs null * Temporarily disabling _mb func tests for monitoring We did this for master but now need to do it for this backport as well, see #98238 for more info * Fixes incorrect archive path for new test after merge Co-authored-by: Chris Roberson <chrisronline@gmail.com>

* Reenabled _mb suffixed stack monitoring func tests These tests were disabled temporarily in #98238 because of intermittent failures in master. * use test_user instead of basic_monitoring_user * remove security service * remove logout and cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: neptunian <sandra.gonzales@elastic.co>

* Reenabled _mb suffixed stack monitoring func tests These tests were disabled temporarily in elastic#98238 because of intermittent failures in master. * use test_user instead of basic_monitoring_user * remove security service * remove logout and cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: neptunian <sandra.gonzales@elastic.co>

* Reenabled _mb suffixed stack monitoring func tests These tests were disabled temporarily in elastic#98238 because of intermittent failures in master. * use test_user instead of basic_monitoring_user * remove security service * remove logout and cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: neptunian <sandra.gonzales@elastic.co> # Conflicts: # x-pack/test/functional/apps/monitoring/index.js

* Reenabled _mb suffixed stack monitoring func tests These tests were disabled temporarily in #98238 because of intermittent failures in master. * use test_user instead of basic_monitoring_user * remove security service * remove logout and cleanup Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: neptunian <sandra.gonzales@elastic.co> Co-authored-by: Jason Rhodes <jason.rhodes@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Skip flaky monitoring/elasticsearch tests

ab810b3

brianseeders added release_note:skip Skip the PR/issue when compiling release notes skipped-test v8.0.0 labels Apr 24, 2021

Skip only/all _mb tests

149170c

brianseeders changed the title ~~Skip flaky monitoring/elasticsearch tests~~ Skip flaky monitoring/*_mb tests Apr 24, 2021

jasonrhodes approved these changes Apr 24, 2021

View reviewed changes

brianseeders mentioned this pull request Apr 24, 2021

/x-pack/test/functional/apps/monitoring/*/*_mb - test suites have various failures #98239

Open

brianseeders added the Team:Operations Kibana-Operations Team label Apr 24, 2021

brianseeders marked this pull request as ready for review April 24, 2021 01:08

brianseeders enabled auto-merge (squash) April 24, 2021 01:08

brianseeders disabled auto-merge April 24, 2021 03:39

brianseeders merged commit 6fbc39d into elastic:master Apr 24, 2021

brianseeders deleted the skip-monitoring-es-tests branch April 24, 2021 03:41

simianhacker added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Apr 26, 2021

jasonrhodes added a commit to jasonrhodes/kibana that referenced this pull request Apr 26, 2021

Reenabled _mb suffixed stack monitoring func tests

d898703

These tests were disabled temporarily in elastic#98238 because of intermittent failures in master.

jasonrhodes added Feature:Stack Monitoring Team:Monitoring Stack Monitoring team labels Apr 26, 2021

jasonrhodes mentioned this pull request Apr 26, 2021

Re-enable _mb suffixed stack monitoring func tests #98354

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 27, 2021

brianseeders added the backport:skip This PR does not require backporting label Apr 27, 2021

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 27, 2021

jasonrhodes added a commit to jasonrhodes/kibana that referenced this pull request Apr 28, 2021

Temporarily disabling _mb func tests for monitoring

6d923b5

We did this for master but now need to do it for this backport as well, see elastic#98238 for more info

neptunian mentioned this pull request May 26, 2021

[Stack Monitoring] Specify user if prompted to login #100732

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip flaky monitoring/*_mb tests#98238

Skip flaky monitoring/*_mb tests#98238
brianseeders merged 2 commits intoelastic:masterfrom
brianseeders:skip-monitoring-es-tests

brianseeders commented Apr 24, 2021

Uh oh!

jasonrhodes commented Apr 24, 2021

Uh oh!

jasonrhodes left a comment

Uh oh!

elasticmachine commented Apr 24, 2021

Uh oh!

kibanamachine commented Apr 24, 2021 •

edited

Loading

Standard Out

Stack Trace

Uh oh!

elasticmachine commented Apr 26, 2021

Uh oh!

elasticmachine commented Apr 26, 2021

Uh oh!

kibanamachine commented Apr 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

brianseeders commented Apr 24, 2021

Uh oh!

jasonrhodes commented Apr 24, 2021

Uh oh!

jasonrhodes left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 24, 2021

Uh oh!

kibanamachine commented Apr 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Uh oh!

elasticmachine commented Apr 26, 2021

Uh oh!

elasticmachine commented Apr 26, 2021

Uh oh!

kibanamachine commented Apr 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kibanamachine commented Apr 24, 2021 •

edited

Loading