Skip to content

[K8] Small fixes#98099

Merged
andreadelrio merged 7 commits intoelastic:masterfrom
andreadelrio:ams-fixes
Apr 27, 2021
Merged

[K8] Small fixes#98099
andreadelrio merged 7 commits intoelastic:masterfrom
andreadelrio:ams-fixes

Conversation

@andreadelrio
Copy link
Copy Markdown
Contributor

@andreadelrio andreadelrio commented Apr 23, 2021

Summary

Fixes the following style issues found in K8

  • Index Management - Add FilterGroup missing around FilterButtons (also needed in K7)

image 6

  • Dashboard - Align toolbar buttons style to match Lens’

image 14

  • Dashboard - Align header button with KQL search bar

image 11

  • Dashboard - Fix chunky panel borders in Edit mode

image 15

  • Discover - Add padding to “Filter by type” popover

image 16

Fixes #97454

@andreadelrio andreadelrio requested a review from a team as a code owner April 23, 2021 00:30
@andreadelrio andreadelrio requested a review from a team April 23, 2021 00:30
@andreadelrio andreadelrio requested a review from a team as a code owner April 23, 2021 00:30
@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Apr 23, 2021
@andreadelrio andreadelrio added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Apr 23, 2021
@andreadelrio
Copy link
Copy Markdown
Contributor Author

andreadelrio commented Apr 23, 2021

@elasticmachine merge upstream

yuliacech
yuliacech approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these fixes, @andreadelrio! ES UI changes LGTM 👍

ryankeairns
ryankeairns approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crosses off several items that I've been seeing, thank you!

Is there any benefit to setting some of these regardless of theme version? My thinking is that some of these may not change the V7 styles even though they address V8 issues. The added benefit is likely small though... we just wouldn't have to clean this up later once V7 is removed.

ryankeairns
ryankeairns reviewed Apr 26, 2021
View reviewed changes
kertal
kertal approved these changes Apr 27, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM in Discover 👍 , checked Safari, Firefox, Chrome, Mac OS

@kertal
Copy link
Copy Markdown
Member

kertal commented Apr 27, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Apr 27, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 410.9KB 410.9KB +26.0B
indexManagement 1.3MB 1.3MB +109.0B
total +135.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 178.9KB 179.0KB +156.0B
navigation 18.0KB 18.0KB +32.0B
presentationUtil 40.3KB 40.5KB +252.0B
total +440.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andreadelrio andreadelrio merged commit 8de7669 into elastic:master Apr 27, 2021
andreadelrio added a commit to andreadelrio/kibana that referenced this pull request Apr 27, 2021
@andreadelrio
[K8] Small fixes (elastic#98099)
ece5134
@andreadelrio andreadelrio mentioned this pull request Apr 27, 2021
Merged
andreadelrio added a commit that referenced this pull request Apr 27, 2021
@andreadelrio
[K8] Small fixes (#98099) (#98507)
70d9aa6
@yuliacech yuliacech mentioned this pull request Jul 19, 2021
Merged
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request Jul 19, 2021
@andreadelrio @yuliacech
[K8] Small fixes (elastic#98099)
1429bb4 
# Conflicts:
#	src/plugins/discover/public/application/components/sidebar/discover_field_search.tsx
#	src/plugins/presentation_util/public/components/solution_toolbar/items/button.scss
@yuliacech yuliacech mentioned this pull request Jul 19, 2021
Merged
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request Jul 19, 2021
@andreadelrio @yuliacech
[K8] Small fixes (elastic#98099)
70f3458 
# Conflicts:
#	src/plugins/discover/public/application/components/sidebar/discover_field_search.tsx
yuliacech added a commit that referenced this pull request Jul 19, 2021
@yuliacech @andreadelrio
[K8] Small fixes (#98099) (#106096)
735c04d 
# Conflicts:
#	src/plugins/discover/public/application/components/sidebar/discover_field_search.tsx
#	src/plugins/presentation_util/public/components/solution_toolbar/items/button.scss

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
yuliacech added a commit that referenced this pull request Jul 19, 2021
@yuliacech
Revert "[K8] Small fixes (#98099) (#106096)"
07c2193 
This reverts commit 735c04d.
yuliacech added a commit that referenced this pull request Jul 19, 2021
@yuliacech @andreadelrio @kibanamachine
[7.14] [K8] Small fixes (#98099) (#106098)
161b884 
* [K8] Small fixes (#98099)

# Conflicts:
#	src/plugins/discover/public/application/components/sidebar/discover_field_search.tsx

* Fixing the merge conflict change

Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@kertal kertal kertal approved these changes

+1 more reviewer

@yuliacech yuliacech yuliacech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v7.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shared toolbar - match button styles to Lens

5 participants

@andreadelrio @kertal @kibanamachine @ryankeairns @yuliacech