Visualize data table: Summary row is detached and jumps in Firefox#97083
Visualize data table: Summary row is detached and jumps in Firefox#97083VladLasitsa merged 6 commits intoelastic:masterfrom
Conversation
|
Hey @VladLasitsa , thanks for the PR. Once you're ready for a review, please click the 'Ready for review' button and move this out of Draft. |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
|
I'm now on FF v87 and can neither re-create the prior issue nor confirm the fix. Perhaps others have an older version. Also, depending on how this turns out, this may become a fix on the EUI side. |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
stratoula
left a comment
There was a problem hiding this comment.
@ryankeairns I am on FF v87 and I can confirm that the bug is still valid. This PR definitely fixes it so I approve it but as I remember that @kertal has also identified a problem with FF and Discover table, maybe it would be better to fix it on Eui side (?) Whatever you want!
ryankeairns
left a comment
There was a problem hiding this comment.
@VladLasitsa please add one additional comment, then this can merged. Thank you!
|
|
||
| // Sticky footer doesn't correct work with inline-flex in Firefox. | ||
| // As footer the last element I don't see any reason to use inline-flex for this element. | ||
| // Display: flex fixes jumping on hover in Firefox. |
There was a problem hiding this comment.
Please add a comment with a link to this related EUI issue - elastic/eui#4729
Once addressed, we can remove this local fix
There was a problem hiding this comment.
@ryankeairns @chandlerprall FYI setting
.euiDataGridHeader
{
display: flex;
}
also resolves Discover's header position problem in Firefox, just tried it out, works
@stratoula thx for the ping @stratoula , tried a similar solution like in this PR @VladLasitsa , and it would also work in Discover, great finding Vlad! |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @VladLasitsa |
|
@elasticmachine run elasticsearch-ci/docs |
…lastic#97083) * Use display: flex for footer in table * Update table_visualization.scss * Update table_visualization.scss Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes: #92816
Summary
Use display: flex for footer in table instead inline-flex. It fix jumping in FIrefox.