[Exploratory view] Improve/Polish components usage#96782
Merged
shahzad31 merged 19 commits intoelastic:masterfrom Apr 15, 2021
Merged
[Exploratory view] Improve/Polish components usage#96782shahzad31 merged 19 commits intoelastic:masterfrom
shahzad31 merged 19 commits intoelastic:masterfrom
Conversation
c448815 to
94be1c3
Compare
Contributor
There was a problem hiding this comment.
Labels are looking good. View still isn't looking so great on smaller screens, but I'm not sure what the expectation is there.
Currently, clicking on any data type other than RUM will break the view. Is the intention to remove/hide these options prior to FF?
...ability/public/components/shared/exploratory_view/series_builder/columns/date_picker_col.tsx
Outdated
Show resolved
Hide resolved
...ns/observability/public/components/shared/exploratory_view/series_builder/series_builder.tsx
Outdated
Show resolved
Hide resolved
...vability/public/components/shared/exploratory_view/series_editor/columns/filter_expanded.tsx
Outdated
Show resolved
Hide resolved
...gins/observability/public/components/shared/exploratory_view/series_editor/series_editor.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
… into polish-components
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 15, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Apr 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of in series to fix https://github.com/elastic/uptime-dev/issues/46
Use better component, improved responsiveness, added labels for report definition components