Skip to content

Stacked line charts incorrectly shows one term as 100%#96203

Merged
VladLasitsa merged 11 commits intoelastic:masterfrom
VladLasitsa:29386
Apr 12, 2021
Merged

Stacked line charts incorrectly shows one term as 100%#96203
VladLasitsa merged 11 commits intoelastic:masterfrom
VladLasitsa:29386

Conversation

@VladLasitsa
Copy link
Copy Markdown
Contributor

Closes: #29386

Summary

Metric is always stacked if the referenced axis is "percentage".

Recording.2.mp4

@VladLasitsa VladLasitsa requested a review from alexwizp April 5, 2021 10:06
@VladLasitsa
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@VladLasitsa VladLasitsa self-assigned this Apr 6, 2021
@alexwizp alexwizp requested a review from stratoula April 8, 2021 12:34
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VladLasitsa VladLasitsa added release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.13.0 v8.0.0 labels Apr 8, 2021
@VladLasitsa VladLasitsa marked this pull request as ready for review April 8, 2021 12:45
@VladLasitsa VladLasitsa requested a review from a team April 8, 2021 12:45
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@VladLasitsa
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@VladLasitsa
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@VladLasitsa
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally in Chrome and works fine

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeXy 110.9KB 111.4KB +505.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@timroes
Copy link
Copy Markdown
Contributor

timroes commented Apr 12, 2021

@elasticmachine run elasticsearch-ci/docs

@VladLasitsa VladLasitsa merged commit 886d7e0 into elastic:master Apr 12, 2021
VladLasitsa added a commit to VladLasitsa/kibana that referenced this pull request Apr 12, 2021
* set "stacked" mode metric if the referenced axis is "percentage"

* Fixed CI

* Move logic inside chart_option component

* Fixed CI

* Update utils.ts

* Update index.tsx

* Update index.tsx

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Apr 12, 2021
…to-metrics-tab

* 'master' of github.com:elastic/kibana: (44 commits)
  [Exploratory View]Additional metrics for kpi over time (elastic#96532)
  [Fleet] UI changes on hosted policy detail view (elastic#96337)
  Stacked line charts incorrectly shows one term as 100% (elastic#96203)
  [Fleet] Create enrollment API keys as current user (elastic#96464)
  [Lens] Make table and metric show on top Chart switcher (elastic#96601)
  skip flaky suite (elastic#96691)
  [Lens] Hide "Show more errors" once expanded (elastic#96605)
  [Discover] Unskip histogram hiding test (elastic#95759)
  skip flyout test, add linked issue elastic#96708
  skip copy_to_space_flyout_internal.test.tsx elastic#96708
  fix config validation (elastic#96502)
  Document telemetry fields for stack security features (elastic#96638)
  [Partial Results] Move inspector adapter integration into search source (elastic#96241)
  [RAC] Rule registry plugin (elastic#95903)
  [APM] Run precommit tasks sequentially (elastic#96551)
  [Maps] fix Kibana does not recognize a valid geo_shape index when attempting to create a Tracking Containment alert (elastic#96633)
  [Security Solution] [Cases] Small UI bugfixes (elastic#96511)
  [Actions UI] Changed PagerDuty action form UI to fill payload fields according to the API docs for Resolve and Acknowledge events. (elastic#96363)
  App Search: Result Component Updates (elastic#96184)
  [Alerting] Preconfigured alert history index connector (elastic#94909)
  ...
VladLasitsa added a commit that referenced this pull request Apr 12, 2021
* set "stacked" mode metric if the referenced axis is "percentage"

* Fixed CI

* Move logic inside chart_option component

* Fixed CI

* Update utils.ts

* Update index.tsx

* Update index.tsx

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@timroes timroes added the Feature:Vis Editor Visualization editor issues label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Vis Editor Visualization editor issues release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stacked line charts incorrectly shows one term as 100%

6 participants