[Fleet] Adding ML module asset type by jgowdyelastic · Pull Request #94950 · elastic/kibana

jgowdyelastic · 2021-03-18T16:57:10Z

Adds support for ML module asset type.

Related to elastic/package-spec#152

elasticmachine · 2021-03-23T12:09:51Z

Pinging @elastic/fleet (Feature:Fleet)

elasticmachine · 2021-03-23T12:09:51Z

Pinging @elastic/ml-ui (:ml)

jgowdyelastic · 2021-03-23T12:14:25Z

@elasticmachine merge upstream

jen-huang

Code LGTM 🚀

ruflin · 2021-03-24T07:18:45Z

It would be good to have a test that installs and removes a package with an ml module to make sure it works as expected. @skh might be able to give some guidance here on how to do this best?

skh · 2021-03-24T08:29:06Z

It would be good to have a test that installs and removes a package with an ml module to make sure it works as expected. @skh might be able to give some guidance here on how to do this best?

#88189 is the PR where we added the lens asset type, and 1c7c7e2 is the commit where the corresponding API integration test is added. I believe for this change the test would look very similar.

jgowdyelastic · 2021-03-26T09:30:54Z

@elasticmachine merge upstream

jgowdyelastic · 2021-03-26T16:58:35Z

It would be good to have a test that installs and removes a package with an ml module to make sure it works as expected. @skh might be able to give some guidance here on how to do this best?

@ruflin tests added

ruflin · 2021-03-29T08:41:48Z

@elasticmachine merge upstream

ruflin

LGTM. @jgowdyelastic Would be good to follow up with an ml module in the integration packages so we can test this in real world.

@EricDavisX Would be nice if this could also be tested manually like install / remove as soon as we have it in a package.

@jen-huang Could you have one more look to make sure this looks as it should?

jgowdyelastic · 2021-03-29T08:56:14Z

@ruflin thank you.
@peteharverson has already begun some end to end tests of this. Using an nginx dataset and a WIP nginx module.

kibanamachine · 2021-03-29T10:58:03Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	716.3KB	716.4KB	+22.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	344.4KB	344.5KB	+80.0B

History

💚 Build #115484 succeeded 2d91ae4
💔 Build #115425 failed c112d6f
💔 Build #114967 failed 05496f2
💔 Build #114860 failed 048444e
💚 Build #114528 succeeded bc2cf6a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

ruflin · 2021-03-29T14:43:28Z

Great to hear @jgowdyelastic . @EricDavisX I think that means you can remove it from your list, sorry for the noise.

Lets get the PR merged then!

* [Fleet] Adding ML module asset type * adding test * guessing asset ids * better guess at IDs * renaming asset ids Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-03-29T15:24:50Z

💚 Backport successful

✅ 7.x / #95665

This backport PR will be merged automatically after passing CI.

* [Fleet] Adding ML module asset type * adding test * guessing asset ids * better guess at IDs * renaming asset ids Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: James Gowdy <jgowdy@elastic.co>

rw-access · 2021-03-31T13:13:46Z

x-pack/test/fleet_api_integration/apis/epm/install_remove_assets.ts

        { id: '47758dc2-979d-5fbe-a2bd-9eded68a5a43', type: 'epm-packages-assets' },
        { id: '318959c9-997b-5a14-b328-9fc7355b4b74', type: 'epm-packages-assets' },
        { id: 'e21b59b5-eb76-5ab0-bef2-1c8e379e6197', type: 'epm-packages-assets' },
+        { id: '4c758d70-ecf1-56b3-b704-6d8374841b34', type: 'epm-packages-assets' },


hey @jgowdyelastic, I'm working on a similar PR #95885 for security_rule assets. how'd you get these UUIDs? I looked through your commits and couldn't reverse engineer your process

@rw-access It took me quite a while to work this out, after adding lots of log statements in fleet I found the best way is to run the tests locally and then copy the IDs out of the errors.
They need to be in the correct order, which again I determined from the test errors.
I'm happy to help if this doesn't work for you.

You need to follow the steps here to run the tests:
https://github.com/elastic/kibana/blob/master/x-pack/plugins/fleet/README.md#tests

[Fleet] Adding ML module asset type

de705f6

jgowdyelastic mentioned this pull request Mar 18, 2021

Support ML module Kibana type elastic/package-spec#152

Merged

2 tasks

jgowdyelastic marked this pull request as ready for review March 23, 2021 12:08

jgowdyelastic requested a review from a team as a code owner March 23, 2021 12:08

jgowdyelastic requested review from ruflin and ycombinator March 23, 2021 12:09

jgowdyelastic self-assigned this Mar 23, 2021

jgowdyelastic added :ml enhancement New value added to drive a business result Feature:Fleet Fleet team's agent central management project release_note:enhancement review v7.13.0 v8.0.0 labels Mar 23, 2021

Merge branch 'master' into adding-ml-module-asset-type-to-fleet

bc2cf6a

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 23, 2021

jen-huang approved these changes Mar 23, 2021

View reviewed changes

jgowdyelastic added 2 commits March 24, 2021 12:06

adding test

048444e

guessing asset ids

05496f2

kibanamachine and others added 3 commits March 26, 2021 05:31

Merge branch 'master' into adding-ml-module-asset-type-to-fleet

6d226e0

better guess at IDs

c112d6f

renaming asset ids

2d91ae4

Merge branch 'master' into adding-ml-module-asset-type-to-fleet

674e0e0

ruflin approved these changes Mar 29, 2021

View reviewed changes

jgowdyelastic added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 29, 2021

jgowdyelastic merged commit 478ad3b into elastic:master Mar 29, 2021

jgowdyelastic deleted the adding-ml-module-asset-type-to-fleet branch March 29, 2021 15:21

kibanamachine mentioned this pull request Mar 29, 2021

[7.x] [Fleet] Adding ML module asset type (#94950) #95665

Merged

rw-access mentioned this pull request Mar 31, 2021

[Fleet] Install security_rule assets as saved objects #95885

Merged

2 tasks

rw-access reviewed Mar 31, 2021

View reviewed changes

peteharverson mentioned this pull request Apr 22, 2021

[ML] [meta] Moving ML modules to fleet integration packages #94704

Closed

6 tasks

peteharverson mentioned this pull request Feb 4, 2022

Add ML modules to Apache integration readme elastic/integrations#2640

Merged

4 tasks

mgiota mentioned this pull request Jun 27, 2024

[SLOs][Fleet] Install integration SLO assets #186974

Closed

Conversation

jgowdyelastic commented Mar 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Mar 23, 2021

Uh oh!

elasticmachine commented Mar 23, 2021

Uh oh!

jgowdyelastic commented Mar 23, 2021

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

ruflin commented Mar 24, 2021

Uh oh!

skh commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jgowdyelastic commented Mar 26, 2021

Uh oh!

jgowdyelastic commented Mar 26, 2021

Uh oh!

ruflin commented Mar 29, 2021

Uh oh!

ruflin left a comment

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic commented Mar 29, 2021

Uh oh!

kibanamachine commented Mar 29, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

ruflin commented Mar 29, 2021

Uh oh!

kibanamachine commented Mar 29, 2021

💚 Backport successful

Uh oh!

rw-access Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jgowdyelastic Mar 31, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jgowdyelastic commented Mar 18, 2021 •

edited

Loading

skh commented Mar 24, 2021 •

edited

Loading

rw-access Mar 31, 2021 •

edited

Loading