Use consistent-type-imports lint rule to autofix type-only imports#94464
Merged
jfsiii merged 5 commits intoelastic:masterfrom Mar 15, 2021
jfsiii:fleet-add-import-type-lint-rule
Merged
Use consistent-type-imports lint rule to autofix type-only imports#94464jfsiii merged 5 commits intoelastic:masterfrom jfsiii:fleet-add-import-type-lint-rule
jfsiii merged 5 commits intoelastic:masterfrom
jfsiii:fleet-add-import-type-lint-rule
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @jfsiii |
skh
approved these changes
Mar 15, 2021
Contributor
skh
left a comment
There was a problem hiding this comment.
I did not review every file. I trust the new lint rule, and CI, so 🚀
Contributor
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually, check out the target branch and run: |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
jfsiii
pushed a commit
that referenced
this pull request
Mar 17, 2021
…94464) (#94868) ## Summary Use the [`consistent-type-imports` lint rule ](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/consistent-type-imports.md) to use `import type ...` where possible Code-only changes like this were recently added in #92979, but it was a more manual process. This PR adds an autofixable lint rule which will keep the changes up-to-date and Just Work ™️ # Conflicts: # x-pack/plugins/fleet/server/services/agents/crud.ts # x-pack/plugins/fleet/server/services/artifacts/artifacts.ts # x-pack/plugins/fleet/server/services/artifacts/mappings.ts # x-pack/plugins/fleet/server/services/artifacts/mocks.ts # x-pack/plugins/fleet/server/services/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the
consistent-type-importslint rule to useimport type ...where possibleCode-only changes like this were recently added in #92979, but it was a more manual process. This PR adds an autofixable lint rule which will keep the changes up-to-date and Just Work ™️