[DOCS] Updates advanced settings doc#93968
Merged
gchaps merged 11 commits intoelastic:masterfrom Apr 8, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-docs (Team:Docs) |
wylieconlon
previously requested changes
Mar 8, 2021
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
Left a suggestion to fully explain what this setting does and how we use it.
Comment on lines
+122
to
+123
| Date histograms are not generated with more bars than the value of this property, | ||
| scaling values when necessary. | ||
| scaling values when necessary. This setting affects *Lens*. |
Contributor
There was a problem hiding this comment.
Let's unify this whole sentence so the descriptions are parallel.
[[histogram-maxbars]]`histogram:maxBars`::
Limits the density of histograms in Lens and aggregation-based visualizations for better performance by making a test query before the main query. If the test query would produce more buckets than this setting allows, the interval between buckets will be increased. If multiple aggregations are used in each chart, this setting is applied separately to each one. To find the maximum value of this setting, divide the {es} `search.max_buckets` value by maximum number of aggregations in each visualization.
Comment on lines
+136
to
+139
| [[metrics-maxbuckets]]`metrics:max_buckets`:: | ||
| The maximum numbers of buckets that a single data source can return. This might | ||
| arise when the user selects a short interval (for example, 1s) for a long time | ||
| period (1 year). | ||
| period (1 year). This setting affects *TSVB* only. |
Contributor
There was a problem hiding this comment.
Let's unify this whole sentence so the descriptions are parallel.
[[metrics-maxbuckets]]`metrics:max_buckets`::
Limits the density of the TSVB histogram for better performance by making a test query before the main query. If the test query would produce more buckets than this setting allows, the interval between buckets will be increased. To find the maximum value of this setting, divide the {es} `search.max_buckets` value by the maximum number of "group by" buckets that you will allow in TSVB.
wylieconlon
reviewed
Mar 9, 2021
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
I've now pushed my own changes to this, so I think we'll need someone else on the team to review.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
streamich
approved these changes
Apr 7, 2021
Contributor
streamich
left a comment
There was a problem hiding this comment.
AppService file changes LGTM.
Contributor
Author
|
@elasticmachine merge upstream |
KOTungseth
approved these changes
Apr 8, 2021
wylieconlon
approved these changes
Apr 8, 2021
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
I agree with @KOTungseth's comments, but I don't think I need to do another review. LGTM
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Search Sessions Integration.x-pack/test/search_sessions_integration/tests/apps/dashboard/async_search/async_search·ts.Dashboard dashboard with async search multiple searches are grouped and only single error popup is shownStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: |
gchaps
added a commit
to gchaps/kibana
that referenced
this pull request
Apr 8, 2021
* [DOCS] Updates advanced settings doc * [DOCS] Edits advanced settings doc * [DOCS] Updates descriptions per review comments * Clarify that TSVB setting is dependent on the other setting * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Wylie Conlon <wylieconlon@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
gchaps
added a commit
that referenced
this pull request
Apr 8, 2021
* [DOCS] Updates advanced settings doc * [DOCS] Edits advanced settings doc * [DOCS] Updates descriptions per review comments * Clarify that TSVB setting is dependent on the other setting * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Wylie Conlon <wylieconlon@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Wylie Conlon <wylieconlon@gmail.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
gchaps
added a commit
to gchaps/kibana
that referenced
this pull request
Apr 12, 2021
* [DOCS] Updates advanced settings doc * [DOCS] Edits advanced settings doc * [DOCS] Updates descriptions per review comments * Clarify that TSVB setting is dependent on the other setting * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Wylie Conlon <wylieconlon@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
gchaps
added a commit
that referenced
this pull request
Apr 12, 2021
* [DOCS] Updates advanced settings doc * [DOCS] Edits advanced settings doc * [DOCS] Updates descriptions per review comments * Clarify that TSVB setting is dependent on the other setting * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> * Update docs/management/advanced-options.asciidoc Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Wylie Conlon <wylieconlon@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co> Co-authored-by: Wylie Conlon <wylieconlon@gmail.com> Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR clarifies difference between the
histogram:maxBarsandmetrics:max_bucketsadvanced settings.histogram:maxBarsis for Lens andmetrics:max_bucketsis for TSVB.Preview:
https://kibana_93968.docs-preview.app.elstc.co/guide/en/kibana/master/advanced-options.html
Closes #68104