[Alerting] Update UI to reflect new terminology#93597
Conversation
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
|
jenkins retest this please |
| @@ -0,0 +1,58 @@ | |||
| [role="xpack"] | |||
| [[alert-management]] | |||
| === Managing Rules | |||
There was a problem hiding this comment.
Should we be referring to these as "Alerting Rules" here? 🤔
I'm not 100% sure when we should use the whole term rather than just "Rules"...
There was a problem hiding this comment.
Since this is under the Rules and Connectors page and there's a sibling page called Managing Connectors, I think Managing Rules is ok here? I'll let @gchaps be the final judge :)
|
Should this dropdown be relabeled? Not sure... so just floating the question.
|
|
The Alerting Example app still uses the legacy terminology. I know I'm moving the goal posts here as I forgot about it 😆 sorry about that.
|
gmmorris
left a comment
There was a problem hiding this comment.
I've looked through the docs and UI, and it all looks spot on :)
Asked a couple of questions, but broadly, looks like all bases have been covered 😄
I debated this as well and kept it for the same reason you mentioned: it is specifically referencing the action in the context of a rule. |
Updated! |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ymao1 |
|
@gchaps I am merging this PR because it contains a lot of changed files and I want to avoid too many conflicts. I will address any docs feedback you have separately. |
* Renaming alerts to rules * Updating formatted messages * Updating i18n labels * Completed renaming in UI * Updating client routes including redirect * wip docs update * Reverting title changes for now * Fixing types check * Fixing unit tests * Fixing functional test * Fixing functional test * docs wip * wip docs update * Finished first run through docs * docs docs docs * Fixing bad merge * Fixing functional test * Docs cleanup * Cleaning up i18n labels * Fixing functional test * Updating screenshots * Updating screenshots * Updating screenshots * Updating terminology in alerting examples * Updating terminology in alerting examples Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Renaming alerts to rules * Updating formatted messages * Updating i18n labels * Completed renaming in UI * Updating client routes including redirect * wip docs update * Reverting title changes for now * Fixing types check * Fixing unit tests * Fixing functional test * Fixing functional test * docs wip * wip docs update * Finished first run through docs * docs docs docs * Fixing bad merge * Fixing functional test * Docs cleanup * Cleaning up i18n labels * Fixing functional test * Updating screenshots * Updating screenshots * Updating screenshots * Updating terminology in alerting examples * Updating terminology in alerting examples Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: ymao1 <ying.mao@elastic.co>
Resolves #92166
Summary
Alerts->RulesandActions->Connectorsin UI/alertsand/alert/{alertId}to/rulesand/rule/{ruleId}and added redirect to make sure old URLs redirect to new URLsUpdated docs (these are the entry points to all the updated doc pages)
https://kibana_93597.docs-preview.app.elstc.co/guide/en/kibana/master/managing-alerts-and-actions.html
https://kibana_93597.docs-preview.app.elstc.co/guide/en/kibana/master/alerting-getting-started.html
Checklist
Delete any items that are not applicable to this PR.