[Security Solution][Detections] Fixes nondeterminism in integration tests#93350
Merged
rylnd merged 1 commit intoelastic:masterfrom Mar 3, 2021
Merged
[Security Solution][Detections] Fixes nondeterminism in integration tests#93350rylnd merged 1 commit intoelastic:masterfrom
rylnd merged 1 commit intoelastic:masterfrom
Conversation
The threat intel data that we are loading for these tests was previously copy/pasted, resulting in all docs having the same @timestamp value. This resulted in nondeterministic ordering which manifested as test failures. This fixes the issue by giving a unique timestamp to each indicator document, and then unskips/updates tests according to this new ordering.
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @rylnd |
FrankHassanabad
approved these changes
Mar 3, 2021
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Mar 3, 2021
The threat intel data that we are loading for these tests was previously copy/pasted, resulting in all docs having the same @timestamp value. This resulted in nondeterministic ordering which manifested as test failures. This fixes the issue by giving a unique timestamp to each indicator document, and then unskips/updates tests according to this new ordering.
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Mar 3, 2021
The threat intel data that we are loading for these tests was previously copy/pasted, resulting in all docs having the same @timestamp value. This resulted in nondeterministic ordering which manifested as test failures. This fixes the issue by giving a unique timestamp to each indicator document, and then unskips/updates tests according to this new ordering.
mistic
added a commit
that referenced
this pull request
Mar 3, 2021
…)" This reverts commit 3ce614f.
Contributor
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 4, 2021
* master: (48 commits) Fix wrong import in data plugin causing 100kB bundle increase (elastic#93448) [Fleet] Correctly track install status of an integration (elastic#93464) Reviews data frame analytics UI text (elastic#93033) Display multiple copyable fields for process.args in resolver node detail panel (elastic#93280) [Security Solution][Detections] ML Popover overflow fix (elastic#93525) chore(NA): do not use execa on bazel workspace status update script (elastic#93532) Bump dependencies (elastic#93511) [dev/build_ts_refs] support disabling the ts-refs build completely (elastic#93529) [Security Solution] fix data provider cypress test (elastic#93465) Fix service map for All environment single service (elastic#93517) [Fleet] Fix package version comparaison in the UI (elastic#93498) [alerting] adds doc on JSON-expanded action variables and task manager max_workers (elastic#92720) [dev/build_ts_refs] ignore type checking failures when building ts refs (elastic#93473) [core-new-docs] Adds a dev-doc for core documentation (elastic#92976) remove opacity from maps legacy style (elastic#93456) [Security Solution][Lists] Escape quotes in list ids and quote the id in KQL query (elastic#93176) Revert "Make tests deterministic by providing unique timestamps (elastic#93350)" [Discover] Fix link from dashboard saved search to Discover (elastic#92937) update public api docs App Search - Polishing Analytics Views (elastic#92939) ...
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
Author
|
skipping backport notifications as this was reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #93152.
The threat intel data that we load for these tests was copy/pasted, resulting in all docs having the same @timestamp value.
This resulted in nondeterministic ordering which manifested as test failures.
This fixes the issue by giving a unique timestamp to each indicator document, and then unskips/updates tests according to this new ordering.
Checklist
Delete any items that are not applicable to this PR.
For maintainers