[XY] Enables page reload toast for the legacyChartsLibrary setting#92811
Merged
stratoula merged 1 commit intoelastic:masterfrom Feb 25, 2021
Merged
[XY] Enables page reload toast for the legacyChartsLibrary setting#92811stratoula merged 1 commit intoelastic:masterfrom
stratoula merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
approved these changes
Feb 25, 2021
Contributor
mbondyra
left a comment
There was a problem hiding this comment.
didn't test, but looks good 🆗
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/cross_cluster_replication/feature_controls/ccr_security·ts.Cross Cluster Replication app feature controls security global dashboard read with ccr_user should render the "Data" section with CCRStandard OutStack TraceMetrics [docs]
To update your PR or re-run it, just comment with: |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Feb 25, 2021
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Feb 25, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 25, 2021
…tiple-searchable-snapshot-actions * 'master' of github.com:elastic/kibana: [Rollup] Fix use of undefined value in JS import (elastic#92791) [ILM] Fix replicas not showing (elastic#92782) [Event Log] Extended README.md with the documentation for a REST API and Start plugin contract. (elastic#92562) [XY] Enables page reload toast for the legacyChartsLibrary setting (elastic#92811) [Security Solution][Case] Improve hooks (elastic#89580) [Security Solution] Update wordings and breadcrumb for timelines page (elastic#90809) [Security Solution] Replace EUI theme with mocks in jest suites (elastic#92462) docs: ✏️ use correct heading level (elastic#92806) [ILM ] Fix logic for showing/hiding recommended allocation on Cloud (elastic#90592) [Security Solution][Detections] Pull gap detection logic out in preparation for sharing between rule types (elastic#91966) [core.savedObjects] Remove _shard_doc tiebreaker since ES now adds it automatically. (elastic#92295) docs: ✏️ fix links in embeddable plugin readme (elastic#92778) # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
stratoula
added a commit
that referenced
this pull request
Feb 25, 2021
stratoula
added a commit
that referenced
this pull request
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #92804
Enables the
requiredPageReloadflag in order for the following toast to be visible.