Skip to content

[Maps] fix selecting EMS basemap does not populate input#92711

Merged
nreese merged 2 commits intoelastic:masterfrom
nreese:issue_92659
Feb 26, 2021
Merged

[Maps] fix selecting EMS basemap does not populate input#92711
nreese merged 2 commits intoelastic:masterfrom
nreese:issue_92659

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Feb 24, 2021

Fixes #92659

Selected configuration state was never getting saved anywhere or passed into TileServiceSelect. This PR just creates a simple component to hold selected configuration state.

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 696 697 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +883.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating a state handler for this! lgtm

  • code review

@nreese nreese added v7.13.0 and removed v7.11.0 labels Feb 26, 2021
@nreese nreese merged commit e409405 into elastic:master Feb 26, 2021
nreese added a commit to nreese/kibana that referenced this pull request Feb 26, 2021
* [Maps] fix selecting EMS basemap does not populate input

* tslint
nreese added a commit to nreese/kibana that referenced this pull request Feb 26, 2021
* [Maps] fix selecting EMS basemap does not populate input

* tslint
nreese added a commit that referenced this pull request Feb 26, 2021
…2943)

* [Maps] fix selecting EMS basemap does not populate input

* tslint
nreese added a commit that referenced this pull request Feb 26, 2021
…2944)

* [Maps] fix selecting EMS basemap does not populate input

* tslint
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 26, 2021
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: (40 commits)
  [Security Solution][Case][Bug] Improve case logging (elastic#91924)
  [Alerts][Doc] Added README documentation for alerts plugin status and framework health checks configuration options. (elastic#92761)
  Add warning for EQL and Threshold rules if exception list contains value list items (elastic#92914)
  [Security Solution][Case] Fix subcases bugs on detections and case view (elastic#91836)
  [APM] Always allow access to Profiling via URL (elastic#92889)
  [Vega] Allow image loading without CORS policy by changing the default to crossOrigin=null (elastic#91991)
  skip flaky suite (elastic#92114)
  [APM] Fix for default fields in correlations view (elastic#91868) (elastic#92090)
  chore(NA): bump bazelisk to v1.7.5 (elastic#92905)
  [Maps] fix selecting EMS basemap does not populate input (elastic#92711)
  API docs (elastic#92827)
  [kbn/test] add import/export support to KbnClient (elastic#92526)
  Test fix management scripted field filter functional test and unskip it  (elastic#92756)
  [App Search] Create Curation view/functionality (elastic#92560)
  [Reporting/Discover] include the document's entire set of fields (elastic#92730)
  [Fleet] Add new index to fleet for artifacts being served out of fleet-server (elastic#92860)
  [Alerts][Doc] Added README documentation for API key invalidation configuration options. (elastic#92757)
  [Discover][docs] Add search for relevance (elastic#90611)
  [Alerts][Docs] Extended README.md and the user docs with the licensing information. (elastic#92564)
  [7.12][Telemetry] Security telemetry allowlist fix. (elastic#92850)
  ...
@timroes timroes added the Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Mar 16, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.12.0 v7.13.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Maps] Selecting EMS basemap does not populate input

5 participants