Skip to content

Mouse out over legend should not cause errors on the console#9263

Merged
epixa merged 1 commit intoelastic:masterfrom
thomasneirynck:fix/9241
Nov 30, 2016
Merged

Mouse out over legend should not cause errors on the console#9263
epixa merged 1 commit intoelastic:masterfrom
thomasneirynck:fix/9241

Conversation

@thomasneirynck
Copy link
Copy Markdown
Contributor

@thomasneirynck thomasneirynck commented Nov 29, 2016

closes #9241.

This is the same spot fix as for the corresponding #8877.

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Nov 29, 2016

Is this happening in 5.1 or 5.0?

@thomasneirynck
Copy link
Copy Markdown
Contributor Author

I can reproduce this on 5.1 and 5.x.

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Nov 29, 2016

I'd say this is a blocker then

@ppisljar
Copy link
Copy Markdown
Contributor

ppisljar commented Nov 30, 2016

shouldn't this be fixed by #8877 ?

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Nov 30, 2016

@ppisljar #8877 failed to address the issue in the "unhighlight" function, which this PR addresses.

@ppisljar
Copy link
Copy Markdown
Contributor

LGTM

@epixa epixa merged commit 1aaa381 into elastic:master Nov 30, 2016
elastic-jasper added a commit that referenced this pull request Nov 30, 2016
Backports PR #9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z
elastic-jasper added a commit that referenced this pull request Nov 30, 2016
Backports PR #9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z
epixa pushed a commit that referenced this pull request Nov 30, 2016
Backports PR #9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z
epixa pushed a commit that referenced this pull request Nov 30, 2016
Backports PR #9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
…#9274)

Backports PR elastic#9263

**Commit 1:**
Mouse out over legend should not cause errors to the console

* Original sha: e688065
* Authored by Thomas Neirynck <thomas@elastic.co> on 2016-11-29T21:44:03Z

Former-commit-id: 59b31e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Area chart error

3 participants