Added alerting ui mock for jest test#92604
Merged
shahzad31 merged 7 commits intoelastic:masterfrom Mar 1, 2021
Merged
Conversation
mikecote
reviewed
Feb 24, 2021
Contributor
There was a problem hiding this comment.
Thanks for the PR!
Could we make the following changes:
- Rename
mock.tstomocks.ts - Use factory pattern for consistency (example:
x-pack/plugins/alerts/server/mocks.ts). - Should be able to access the start mock via something like
triggersActionsUiMock.createStart()
Contributor
Author
|
Add 3.6kb into the page load bundle , i will try to offset with some lazy loading
|
Contributor
|
@shahzad31 feel free to remove the changes in |
Contributor
Author
|
@mikecote ended up spending an hour improving lazy loading in the app. i hope it helps. |
Contributor
Author
|
updated infra paths to use lazy components |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @shahzad31 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 1, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
kibanamachine
added a commit
that referenced
this pull request
Mar 1, 2021
jloleysens
added a commit
that referenced
this pull request
Mar 3, 2021
… ilm/rollup-v2-action * 'ilm/rollup-v2-action' of github.com:elastic/kibana: [Security Solution][Case][Bug] Only add rule object for alert comments (#92977) [Security Solution][Case] Show the current connector name in case view (#93018) [Security Solution] Remove unused mock data (#92357) Adds mapping to the signals for the indicator rules that were missing (#92928) skip flaky suite (#85208) Cleanup spaces plugin (#91976) Control round and decimal places in Gauge Visualization when using aggregate functions like average (#91293) Added alerting ui mock for jest test (#92604) Remove "beta" label from URL Drilldown as it is now GA (#92859)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Needed a mock as can be seen in example PR #91469 to test jest test
so added a mock for alerting UI
Note:
Need to check if this will have any adverse effect on page load bundle size
Update
ended up improving lazy loading in alerting plugin to offset cost