Skip to content

[ci] disable firefox scripts from security cypress job#92483

Merged
yctercero merged 1 commit intoelastic:masterfrom
yctercero:test_patch
Feb 23, 2021
Merged

[ci] disable firefox scripts from security cypress job#92483
yctercero merged 1 commit intoelastic:masterfrom
yctercero:test_patch

Conversation

@yctercero
Copy link
Copy Markdown
Contributor

@yctercero yctercero commented Feb 23, 2021 •
edited
Loading

Summary

Temporarily disabling security solution Firefox tests. Seem to be race conditions present in the Firefox run specifically causing flake.

@yctercero yctercero added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.12.0 v7.13 v8.0.0 labels Feb 23, 2021
@yctercero yctercero self-assigned this Feb 23, 2021
@yctercero yctercero marked this pull request as ready for review February 23, 2021 18:21
@yctercero yctercero requested a review from a team as a code owner February 23, 2021 18:21
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 23, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

spalger
spalger approved these changes Feb 23, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@banderror
Copy link
Copy Markdown
Contributor

banderror commented Feb 23, 2021

🙏

@yctercero yctercero added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 23, 2021
@yctercero yctercero enabled auto-merge (squash) February 23, 2021 19:56
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 23, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit d847958 into elastic:master Feb 23, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 23, 2021

💔 Backport failed

❌ 7.12: Commit could not be cherrypicked due to conflicts

To backport manually, check out the target branch and run:
node scripts/backport --pr 92483

@yctercero yctercero mentioned this pull request Feb 23, 2021
Merged
yctercero added a commit to yctercero/kibana that referenced this pull request Feb 23, 2021
@yctercero
[ci] disable firefox scripts from security cypress job (elastic#92483)
d92cde0 
Temporarily disabling security solution Firefox tests. Seem to be race conditions present in the Firefox run specifically causing flake.
# Conflicts:
#	.ci/Jenkinsfile_security_cypress
@yctercero yctercero mentioned this pull request Feb 23, 2021
Merged
yctercero added a commit to yctercero/kibana that referenced this pull request Feb 23, 2021
@yctercero
[ci] disable firefox scripts from security cypress job (elastic#92483)
3e64c1a 
Temporarily disabling security solution Firefox tests. Seem to be race conditions present in the Firefox run specifically causing flake.
# Conflicts:
#	.ci/Jenkinsfile_security_cypress
#	vars/tasks.groovy
yctercero added a commit that referenced this pull request Feb 23, 2021
@yctercero
[ci] disable firefox scripts from security cypress job (#92483) (#92515)
fe84df1 
Temporarily disabling security solution Firefox tests. Seem to be race conditions present in the Firefox run specifically causing flake.
# Conflicts:
#	.ci/Jenkinsfile_security_cypress
yctercero added a commit that referenced this pull request Feb 23, 2021
@yctercero
[7.12] [ci] disable firefox scripts from security cypress job (#92483) (
5b4361f 
#92516)

* [ci] disable firefox scripts from security cypress job (#92483)

Temporarily disabling security solution Firefox tests. Seem to be race conditions present in the Firefox run specifically causing flake.
# Conflicts:
#	.ci/Jenkinsfile_security_cypress
#	vars/tasks.groovy

* fix merge conflict
@yctercero yctercero added v7.13.0 and removed v7.12.0 labels Feb 25, 2021
@yctercero
Copy link
Copy Markdown
Contributor Author

yctercero commented Feb 25, 2021

Note - this should not have been backported to 7.12 as original change, though labeled as such, had not been backported to 7.12. #92882 reverts this change in 7.12 branch.

@yctercero yctercero deleted the test_patch branch October 13, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spalger spalger spalger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yctercero yctercero

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yctercero @elasticmachine @banderror @kibanamachine @spalger