[5.1]: Trigger renderComplete on DOM instead of the Vis (#9176)#9203
Merged
[5.1]: Trigger renderComplete on DOM instead of the Vis (#9176)#9203
Conversation
Backports PR #9183 **Commit 1:** BACKPORT: Trigger renderComplete on DOM instead of the Vis (#9176) * correctly use implementsRenderComplete from vis config * set implementsRenderComplete on all vis types * emit on DOM instead of the vis * vis doesn't need to be an EventEmitter * listen for renderComplete on visualize set and update element attributes as the event(s) fire, and indicate if they ever will * [vislib/handler] fall through to lower return * [vislibRenderbot/tests] reduce expected call count * [vis/tests] add $element to test injectors * [markdownVis] fix test * Original sha: 7190260 * Authored by Joe Fleming <joe.fleming@gmail.com> on 2016-11-22T16:49:16Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
elastic#9203) Backports PR elastic#9183 **Commit 1:** BACKPORT: Trigger renderComplete on DOM instead of the Vis (elastic#9176) * correctly use implementsRenderComplete from vis config * set implementsRenderComplete on all vis types * emit on DOM instead of the vis * vis doesn't need to be an EventEmitter * listen for renderComplete on visualize set and update element attributes as the event(s) fire, and indicate if they ever will * [vislib/handler] fall through to lower return * [vislibRenderbot/tests] reduce expected call count * [vis/tests] add $element to test injectors * [markdownVis] fix test * Original sha: 7190260 * Authored by Joe Fleming <joe.fleming@gmail.com> on 2016-11-22T16:49:16Z Former-commit-id: 67db8dd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger renderComplete on DOM instead of the Vis (#9176)
Backports PR #9183
Commit 1:
BACKPORT: Trigger renderComplete on DOM instead of the Vis (#9176)
correctly use implementsRenderComplete from vis config
set implementsRenderComplete on all vis types
emit on DOM instead of the vis
vis doesn't need to be an EventEmitter
listen for renderComplete on visualize
set and update element attributes as the event(s) fire, and indicate if
they ever will
[vislib/handler] fall through to lower return
[vislibRenderbot/tests] reduce expected call count
[vis/tests] add $element to test injectors
[markdownVis] fix test
Original sha: 7190260
Authored by Joe Fleming joe.fleming@gmail.com on 2016-11-22T16:49:16Z