Skip to content

[Discover] Always show unmapped fields#91735

Merged
majagrubic merged 5 commits intoelastic:masterfrom
majagrubic:unmapped_fields_default
Feb 19, 2021
Merged

[Discover] Always show unmapped fields#91735
majagrubic merged 5 commits intoelastic:masterfrom
majagrubic:unmapped_fields_default

Conversation

@majagrubic
Copy link
Copy Markdown
Contributor

@majagrubic majagrubic commented Feb 17, 2021 •
edited
Loading

Summary

As per discussion, we'll always request unmapped fields when using the fields API. There will be no user-configurable switch in the UI and no data migration.

This PR removes the switch from the UI and removes the data migration. The unmappedFieldsConfig remains, but we can clean up the code in one of the following PRs.

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

  • Unit or functional tests were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
    - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
    - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
    - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
    - [ ] This was checked for cross-browser compatibility

For maintainers

@majagrubic majagrubic mentioned this pull request Feb 18, 2021
Closed
2 tasks
wylieconlon
wylieconlon reviewed Feb 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wylieconlon wylieconlon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like the right approach based on our latest discussion. The main thing that's missing is integration with the advanced settings.

Edit: I thought we would have an advanced setting related to unmapped fields. If we don't then this PR is the right scope.

@majagrubic majagrubic mentioned this pull request Feb 18, 2021
Merged
3 tasks
@majagrubic majagrubic added v7.12.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 19, 2021
@majagrubic majagrubic marked this pull request as ready for review February 19, 2021 07:08
@majagrubic majagrubic requested a review from a team February 19, 2021 07:08
@majagrubic majagrubic added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Feb 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this pull request Feb 19, 2021
Closed
31 tasks
@flash1293
Copy link
Copy Markdown
Contributor

flash1293 commented Feb 19, 2021

@elasticmachine merge upstream

flash1293
flash1293 approved these changes Feb 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and unmapped fields are shown everywhere. LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 19, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 409.5KB 407.3KB -2.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 79.5KB 79.4KB -47.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
search 11 10 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@majagrubic majagrubic merged commit c8fab9f into elastic:master Feb 19, 2021
@majagrubic majagrubic mentioned this pull request Feb 19, 2021
Merged
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Feb 19, 2021
@kibanamachine
[Discover] Always show unmapped fields (elastic#91735)
774e278 
* [Discover] Always show unmapped fields

* Updating the functional test

* Remove unmapped switch toggle

* Some more code cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Feb 19, 2021
@kibanamachine
[Discover] Always show unmapped fields (elastic#91735)
d052899 
* [Discover] Always show unmapped fields

* Updating the functional test

* Remove unmapped switch toggle

* Some more code cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@majagrubic majagrubic mentioned this pull request Feb 19, 2021
Merged
majagrubic pushed a commit that referenced this pull request Feb 22, 2021
@kibanamachine
[Discover] Always show unmapped fields (#91735) (#92071)
b5f05d6 
* [Discover] Always show unmapped fields

* Updating the functional test

* Remove unmapped switch toggle

* Some more code cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
majagrubic pushed a commit that referenced this pull request Feb 22, 2021
@kibanamachine
[Discover] Always show unmapped fields (#91735) (#92070)
391b3a8 
* [Discover] Always show unmapped fields

* Updating the functional test

* Remove unmapped switch toggle

* Some more code cleanup

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

+1 more reviewer

@wylieconlon wylieconlon wylieconlon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@majagrubic @elasticmachine @flash1293 @kibanamachine @wylieconlon