[ML] Filtering runtime mappings in anomaly detection wizards#91534
Merged
jgowdyelastic merged 4 commits intoelastic:masterfrom Feb 17, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
darnautov
reviewed
Feb 17, 2021
...s/ml/public/application/jobs/new_job/common/job_creator/util/filter_runtime_mappings.test.ts
Outdated
Show resolved
Hide resolved
...lugins/ml/public/application/jobs/new_job/common/job_creator/util/filter_runtime_mappings.ts
Show resolved
Hide resolved
...lugins/ml/public/application/jobs/new_job/common/job_creator/util/filter_runtime_mappings.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
qn895
approved these changes
Feb 17, 2021
Member
|
LGTM |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 17, 2021
…#91534) * [ML] Filtering runtime mappings in anomaly detection wizards * updating tests * adding check for null when parsing aggs * removing async from tests
Contributor
kibanamachine
added a commit
that referenced
this pull request
Feb 17, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime mappings which are not used but in the job or the datafeed's aggregations are removed from the datafeed just before saving the job.
A copy of the datafeed is used for the save, so if the save fails or the user resets the wizard after saving, the original set of runtime mappings is still available.
A currently unused flag
filterRuntimeMappingsOnSavehas been added for a future UI control which will allow the user to disable this auto filtering of the mappings.Related to #91168