Skip to content

[Metrics UI] Fix passing space ID into anomaly alerts#91222

Merged
Zacqary merged 2 commits intoelastic:masterfrom
Zacqary:anomaly-spaceid-fix
Feb 12, 2021
Merged

[Metrics UI] Fix passing space ID into anomaly alerts#91222
Zacqary merged 2 commits intoelastic:masterfrom
Zacqary:anomaly-spaceid-fix

Conversation

@Zacqary
Copy link
Copy Markdown
Contributor

@Zacqary Zacqary commented Feb 11, 2021

Summary

The anomaly alert flyout was not passing the current Space ID into the alert executor or preview function, making all anomaly alerts use the default ID. This PR fixes that.

@Zacqary Zacqary added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 11, 2021
@Zacqary Zacqary requested a review from a team as a code owner February 11, 2021 21:47
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Zacqary Zacqary enabled auto-merge (squash) February 11, 2021 23:13
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.9MB 1.9MB +2.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 189.9KB 189.9KB +22.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 7537326 into elastic:master Feb 12, 2021
@Zacqary Zacqary deleted the anomaly-spaceid-fix branch February 12, 2021 01:06
Zacqary added a commit to Zacqary/kibana that referenced this pull request Feb 12, 2021
* [Metrics UI] Fix passing space ID into anomaly alerts

* Fix jest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants