Unskip and Fix maps x-pack functional test - ( sample data and layer_errors) and also added baseline images#91205
Merged
rashmivkulkarni merged 19 commits intoelastic:masterfrom Feb 11, 2021
Conversation
* unskip maps tests * checking the baseline images * updated the test to move the mouse away and close the Legend * more changes to the test * reducing the threshold limit * updating the baseline images * added a comment about the baseline images * updating flights baseline image and adjusting threshold * updated threshold and baseline image for web log * session image of weblogsmap * skipping layer_errors test * skip the test - as it fails on cloud and windows on snapshot
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
LeeDr
approved these changes
Feb 11, 2021
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - this was a forward port of the fix from 7.11
kindsun
approved these changes
Feb 11, 2021
Contributor
kindsun
left a comment
There was a problem hiding this comment.
Thanks for fixing the skipped tests! My only comment would be that the .02 tolerance range for image comparisons feels pretty tight compared to the old ones, but on that I defer to the QA experts 🙇
- code review
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
3 similar comments
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Feb 19, 2021
…errors) and also added baseline images (elastic#91205) * fixes elastic#74449 * unskip maps tests (elastic#90323) * unskip maps tests * checking the baseline images * updated the test to move the mouse away and close the Legend * more changes to the test * reducing the threshold limit * updating the baseline images * added a comment about the baseline images * updating flights baseline image and adjusting threshold * updated threshold and baseline image for web log * session image of weblogsmap * skipping layer_errors test * skip the test - as it fails on cloud and windows on snapshot
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Feb 19, 2021
…errors) and also added baseline images (elastic#91205) * fixes elastic#74449 * unskip maps tests (elastic#90323) * unskip maps tests * checking the baseline images * updated the test to move the mouse away and close the Legend * more changes to the test * reducing the threshold limit * updating the baseline images * added a comment about the baseline images * updating flights baseline image and adjusting threshold * updated threshold and baseline image for web log * session image of weblogsmap * skipping layer_errors test * skip the test - as it fails on cloud and windows on snapshot
rashmivkulkarni
added a commit
that referenced
this pull request
Feb 19, 2021
…errors) and also added baseline images (#91205) (#91973) * fixes #74449 * unskip maps tests (#90323) * unskip maps tests * checking the baseline images * updated the test to move the mouse away and close the Legend * more changes to the test * reducing the threshold limit * updating the baseline images * added a comment about the baseline images * updating flights baseline image and adjusting threshold * updated threshold and baseline image for web log * session image of weblogsmap * skipping layer_errors test * skip the test - as it fails on cloud and windows on snapshot
rashmivkulkarni
added a commit
that referenced
this pull request
Feb 19, 2021
…errors) and also added baseline images (#91205) (#91972) * fixes #74449 * unskip maps tests (#90323) * unskip maps tests * checking the baseline images * updated the test to move the mouse away and close the Legend * more changes to the test * reducing the threshold limit * updating the baseline images * added a comment about the baseline images * updating flights baseline image and adjusting threshold * updated threshold and baseline image for web log * session image of weblogsmap * skipping layer_errors test * skip the test - as it fails on cloud and windows on snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #90323