[Fleet] Remove aliases from index_template when updating an existing template#91200
Merged
nchaulet merged 4 commits intoelastic:masterfrom Feb 11, 2021
Merged
Conversation
…tall-template-aliases
…tall-template-aliases
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/transform/feature_controls/transform_security·ts.transform feature controls security global dashboard all with transform_user should render the "Data" section with TransformStandard OutStack TraceMetrics [docs]
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Feb 11, 2021
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Feb 11, 2021
…template (elastic#91200) # Conflicts: # x-pack/plugins/fleet/server/services/epm/elasticsearch/template/install.test.ts
nchaulet
added a commit
that referenced
this pull request
Feb 11, 2021
nchaulet
added a commit
that referenced
this pull request
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reapply #91142
The commit was reverted du to a type issue this fix it c5b5f20
This was merged between the CI and the merge of the previous PR #90492
Context
Resolve #90984
Ensure we aliases from index_template when updating an existing index template
When updating an index template we put new component template before updating the index template, this cause validation error in the case where the index template contains the
aliasesproperty. That PR ensure the aliases property is removed before.How to test
Start with a Kibana 7.10 setup fleet and endpoint than update to that PR you should be able to upgrade and go to fleet and the index_template for
logs-endpoint*should not contains aliasesLocally I tested it like this (without the fix I got the issue)
First run kibana from the
7.10branch,yarn es snapshot --license trial --password changeme -E xpack.security.authc.api_key.enabled=true -E path.data=/tmp/es-dataThan checkout that PR
yarn es snapshot --license trial --password changeme -E xpack.security.authc.api_key.enabled=true -E path.data=/tmp/es-dataRelease note
Fix an upgrade issue in Fleet from 7.10 to 7.11 happening with the endpoint package.