[Time to Visualize] Unsaved Changes Badge by ThomThomson · Pull Request #91073 · elastic/kibana

ThomThomson · 2021-02-11T01:31:58Z

Summary

Fixes #88901 by adding a badge to the left of the dashboard top nav which indicates when the dashboard has unsaved changes. This will show regardless of view / edit mode, and will disappear on save, when discarding changes, and if the user manually resets the dashboard to its last saved state.

Note This badge will also show up when the dashboard has been migrated to the latest version. To make this slightly more obvious to users, a toast will appear the first time the migration is run when the dashboard is in edit mode.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

… dashboard title

…coming from

elasticmachine · 2021-02-11T20:01:19Z

Pinging @elastic/kibana-presentation (Team:Presentation)

ryankeairns

Creative way you've wedged that in there :)

Time is of the essence, so I'm marking this approved but did add one small edit. Thanks!

src/plugins/navigation/public/top_nav_menu/top_nav_menu.tsx

clintandrewhall

Nice approach.

ppisljar

app arch changes LGTM

ThomThomson · 2021-02-15T15:06:56Z

@elasticmachine merge upstream

kibanamachine · 2021-02-16T18:46:10Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: b4dc1c6
Documentation Changes
Flaky suites:
- xpack-accessibility

Test Failures

Kibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/kibana_overview·ts.Kibana overview "after all" hook for "Overview view"

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 6 times on tracked branches: https://github.com/elastic/kibana/issues/82226

[00:00:00]       │
[00:04:22]         └-: Kibana overview
[00:04:22]           └-> "before all" hook for "Getting started view"
[00:04:22]           └-> "before all" hook for "Getting started view"
[00:04:22]             │ info [empty_kibana] Loading "mappings.json"
[00:04:22]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_task_manager_8.0.0_001/oBJifY6YSmaZz2N31QrpSg] deleting index
[00:04:22]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_8.0.0_001/Lbk1K1pzTnqCRIp7sEKRoA] deleting index
[00:04:22]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_pre6.5.0_001/V14FyBO3R-O6x8gggGA4OQ] deleting index
[00:04:22]             │ info [empty_kibana] Deleted existing index ".kibana_8.0.0_001"
[00:04:22]             │ info [empty_kibana] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:04:22]             │ info [empty_kibana] Deleted existing index ".kibana_pre6.5.0_001"
[00:04:22]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana] creating index, cause [api], templates [], shards [1]/[1]
[00:04:22]             │ info [empty_kibana] Created index ".kibana"
[00:04:22]             │ debg [empty_kibana] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:04:22]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana/p0pls-UHSdasBZq6gGJJLA] update_mapping [_doc]
[00:04:22]             │ debg Migrating saved objects
[00:04:22]             │ proc [kibana]   log   [17:14:41.674] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET
[00:04:22]             │ proc [kibana]   log   [17:14:41.680] [info][savedobjects-service] [.kibana] INIT -> LEGACY_SET_WRITE_BLOCK
[00:04:22]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:04:22]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:04:22]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] adding block write to indices [[.kibana/p0pls-UHSdasBZq6gGJJLA]]
[00:04:22]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] completed adding block write to indices [.kibana]
[00:04:22]             │ proc [kibana]   log   [17:14:41.752] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY
[00:04:22]             │ proc [kibana]   log   [17:14:41.769] [info][savedobjects-service] [.kibana] LEGACY_SET_WRITE_BLOCK -> LEGACY_CREATE_REINDEX_TARGET
[00:04:22]             │ proc [kibana]   log   [17:14:41.789] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE
[00:04:22]             │ proc [kibana]   log   [17:14:41.789] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 119ms
[00:04:22]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_pre6.5.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:04:22]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] updating number_of_replicas to [0] for indices [.kibana_pre6.5.0_001]
[00:04:22]             │ proc [kibana]   log   [17:14:41.849] [info][savedobjects-service] [.kibana] LEGACY_CREATE_REINDEX_TARGET -> LEGACY_REINDEX
[00:04:22]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] 8931 finished with response BulkByScrollResponse[took=2.6ms,timed_out=false,sliceId=null,updated=0,created=0,deleted=0,batches=0,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:22]             │ proc [kibana]   log   [17:14:41.857] [info][savedobjects-service] [.kibana] LEGACY_REINDEX -> LEGACY_REINDEX_WAIT_FOR_TASK
[00:04:22]             │ proc [kibana]   log   [17:14:41.865] [info][savedobjects-service] [.kibana] LEGACY_REINDEX_WAIT_FOR_TASK -> LEGACY_DELETE
[00:04:22]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana/p0pls-UHSdasBZq6gGJJLA] deleting index
[00:04:22]             │ proc [kibana]   log   [17:14:41.913] [info][savedobjects-service] [.kibana] LEGACY_DELETE -> SET_SOURCE_WRITE_BLOCK
[00:04:22]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] adding block write to indices [[.kibana_pre6.5.0_001/3GTBCgllTOuuunQo0UyqTg]]
[00:04:22]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] completed adding block write to indices [.kibana_pre6.5.0_001]
[00:04:22]             │ proc [kibana]   log   [17:14:41.955] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CREATE_REINDEX_TEMP
[00:04:22]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:04:22]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:04:22]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_reindex_temp][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_reindex_temp][0]]"
[00:04:22]             │ proc [kibana]   log   [17:14:42.019] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP
[00:04:22]             │ proc [kibana]   log   [17:14:42.025] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP -> REINDEX_SOURCE_TO_TEMP_WAIT_FOR_TASK
[00:04:22]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] 8960 finished with response BulkByScrollResponse[took=2.6ms,timed_out=false,sliceId=null,updated=0,created=0,deleted=0,batches=0,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:22]             │ proc [kibana]   log   [17:14:42.034] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_WAIT_FOR_TASK -> SET_TEMP_WRITE_BLOCK
[00:04:22]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] adding block write to indices [[.kibana_8.0.0_reindex_temp/6PFfdEoCS62-cm3A6Yg07Q]]
[00:04:22]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:04:22]             │ proc [kibana]   log   [17:14:42.080] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET
[00:04:22]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:04:22]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:04:22]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:04:22]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_8.0.0_001/153dQ6w8RpeXVm3vJsEI5Q] create_mapping
[00:04:22]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_001][0]]"
[00:04:22]             │ proc [kibana]   log   [17:14:42.188] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> OUTDATED_DOCUMENTS_SEARCH
[00:04:22]             │ proc [kibana]   log   [17:14:42.197] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> UPDATE_TARGET_MAPPINGS
[00:04:22]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_8.0.0_001/153dQ6w8RpeXVm3vJsEI5Q] update_mapping [_doc]
[00:04:23]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] 8996 finished with response BulkByScrollResponse[took=2.6ms,timed_out=false,sliceId=null,updated=0,created=0,deleted=0,batches=0,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:04:23]             │ proc [kibana]   log   [17:14:42.282] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK
[00:04:23]             │ proc [kibana]   log   [17:14:42.288] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY
[00:04:23]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_8.0.0_reindex_temp/6PFfdEoCS62-cm3A6Yg07Q] deleting index
[00:04:23]             │ proc [kibana]   log   [17:14:42.336] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE
[00:04:23]             │ proc [kibana]   log   [17:14:42.337] [info][savedobjects-service] [.kibana] Migration completed after 667ms
[00:04:23]             │ debg [empty_kibana] Migrated Kibana index after loading Kibana data
[00:04:23]             │ debg [empty_kibana] Ensured that default space exists in .kibana
[00:04:23]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:04:23]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1613493239960876673] [.kibana_8.0.0_001/153dQ6w8RpeXVm3vJsEI5Q] update_mapping [_doc]
[00:04:24]             │ debg navigating to kibanaOverview url: http://localhost:6131/app/kibanaOverview
[00:04:24]             │ debg navigate to: http://localhost:6131/app/kibanaOverview
[00:04:25]             │ debg browser[INFO] http://localhost:6131/app/kibanaOverview?_t=1613495684140 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:25]             │
[00:04:25]             │ debg browser[INFO] http://localhost:6131/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:25]             │ debg ... sleep(700) start
[00:04:25]             │ debg ... sleep(700) end
[00:04:25]             │ debg returned from get, calling refresh
[00:04:26]             │ERROR browser[SEVERE] http://localhost:6131/40464/bundles/core/core.entry.js 12:160284 TypeError: Failed to fetch
[00:04:26]             │          at fetch_Fetch.fetchResponse (http://localhost:6131/40464/bundles/core/core.entry.js:6:32451)
[00:04:26]             │          at async interceptResponse (http://localhost:6131/40464/bundles/core/core.entry.js:6:28637)
[00:04:26]             │          at async http://localhost:6131/40464/bundles/core/core.entry.js:6:31117
[00:04:26]             │ debg browser[INFO] http://localhost:6131/app/kibanaOverview?_t=1613495684140 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:26]             │
[00:04:26]             │ debg browser[INFO] http://localhost:6131/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:26]             │ debg currentUrl = http://localhost:6131/app/kibanaOverview
[00:04:26]             │          appUrl = http://localhost:6131/app/kibanaOverview
[00:04:26]             │ debg TestSubjects.find(kibanaChrome)
[00:04:26]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:27]             │ debg TestSubjects.find(kibanaChrome)
[00:04:27]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:04:27]             │ debg ... sleep(501) start
[00:04:27]             │ERROR browser[SEVERE] http://localhost:6131/kibana-analytics/v8.0.0.json - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:04:27]             │ERROR browser[SEVERE] http://localhost:6131/40464/bundles/plugin/newsfeed/newsfeed.plugin.js 0:18917 Error: Not Found
[00:04:27]             │          at fetch_Fetch.fetchResponse (http://localhost:6131/40464/bundles/core/core.entry.js:6:33030)
[00:04:27]             │          at async interceptResponse (http://localhost:6131/40464/bundles/core/core.entry.js:6:28637)
[00:04:27]             │          at async http://localhost:6131/40464/bundles/core/core.entry.js:6:31117
[00:04:27]             │ debg ... sleep(501) end
[00:04:27]             │ debg in navigateTo url = http://localhost:6131/app/kibanaOverview#/
[00:04:27]             │ debg TestSubjects.exists(statusPageContainer)
[00:04:27]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:04:30]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:04:30]           └-> Getting started view
[00:04:30]             └-> "before each" hook: global before each for "Getting started view"
[00:04:31]             └- ✓ pass  (501ms) "Kibana overview Getting started view"
[00:04:31]           └-> Overview view
[00:04:31]             └-> "before each" hook: global before each for "Overview view"
[00:04:31]             │ debg navigateToActualUrl http://localhost:6131/app/home#/tutorial_directory/sampleData
[00:04:31]             │ debg browser[INFO] http://localhost:6131/app/home?_t=1613495690472#/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:31]             │
[00:04:31]             │ debg browser[INFO] http://localhost:6131/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:32]             │ debg currentUrl = http://localhost:6131/app/home#/tutorial_directory/sampleData
[00:04:32]             │          appUrl = http://localhost:6131/app/home#/tutorial_directory/sampleData
[00:04:32]             │ debg TestSubjects.find(kibanaChrome)
[00:04:32]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:32]             │ debg TestSubjects.exists(addSampleDataSetflights)
[00:04:32]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=2500
[00:04:32]             │ debg TestSubjects.click(addSampleDataSetflights)
[00:04:32]             │ debg Find.clickByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:04:32]             │ debg Find.findByCssSelector('[data-test-subj="addSampleDataSetflights"]') with timeout=10000
[00:04:33]             │ debg TestSubjects.find(sampleDataSetCardflights)
[00:04:33]             │ debg Find.findByCssSelector('[data-test-subj="sampleDataSetCardflights"]') with timeout=10000
[00:04:33]             │ERROR browser[SEVERE] http://localhost:6131/api/fleet/settings - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:04:34]             │ debg navigating to kibanaOverview url: http://localhost:6131/app/kibanaOverview
[00:04:34]             │ debg navigate to: http://localhost:6131/app/kibanaOverview
[00:04:34]             │ debg browser[INFO] http://localhost:6131/app/kibanaOverview?_t=1613495693353 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:34]             │
[00:04:34]             │ debg browser[INFO] http://localhost:6131/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:34]             │ debg ... sleep(700) start
[00:04:34]             │ debg ... sleep(700) end
[00:04:34]             │ debg returned from get, calling refresh
[00:04:35]             │ debg browser[INFO] http://localhost:6131/app/kibanaOverview?_t=1613495693353 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:35]             │
[00:04:35]             │ debg browser[INFO] http://localhost:6131/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:36]             │ debg currentUrl = http://localhost:6131/app/kibanaOverview
[00:04:36]             │          appUrl = http://localhost:6131/app/kibanaOverview
[00:04:36]             │ debg TestSubjects.find(kibanaChrome)
[00:04:36]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:36]             │ debg TestSubjects.find(kibanaChrome)
[00:04:36]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:04:36]             │ debg ... sleep(501) start
[00:04:36]             │ERROR browser[SEVERE] http://localhost:6131/kibana-analytics/v8.0.0.json - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:04:36]             │ERROR browser[SEVERE] http://localhost:6131/40464/bundles/plugin/newsfeed/newsfeed.plugin.js 0:18917 Error: Not Found
[00:04:36]             │          at fetch_Fetch.fetchResponse (http://localhost:6131/40464/bundles/core/core.entry.js:6:33030)
[00:04:36]             │          at async interceptResponse (http://localhost:6131/40464/bundles/core/core.entry.js:6:28637)
[00:04:36]             │          at async http://localhost:6131/40464/bundles/core/core.entry.js:6:31117
[00:04:36]             │ debg ... sleep(501) end
[00:04:36]             │ debg in navigateTo url = http://localhost:6131/app/kibanaOverview#/
[00:04:36]             │ debg TestSubjects.exists(statusPageContainer)
[00:04:36]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:04:39]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:04:40]             └- ✓ pass  (9.3s) "Kibana overview Overview view"
[00:04:40]           └-> "after all" hook for "Overview view"
[00:04:40]             │ debg navigateToActualUrl http://localhost:6131/app/home#/tutorial_directory/sampleData
[00:04:40]             │ debg browser[INFO] http://localhost:6131/app/home?_t=1613495699767#/tutorial_directory/sampleData 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:04:40]             │
[00:04:40]             │ debg browser[INFO] http://localhost:6131/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:04:41]             │ debg currentUrl = http://localhost:6131/app/home#/tutorial_directory/sampleData
[00:04:41]             │          appUrl = http://localhost:6131/app/home#/tutorial_directory/sampleData
[00:04:41]             │ debg TestSubjects.find(kibanaChrome)
[00:04:41]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:04:41]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:04:41]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:04:51]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:04:51]             │      Wait timed out after 10070ms
[00:04:51]             │ERROR browser[SEVERE] http://localhost:6131/api/fleet/settings - Failed to load resource: the server responded with a status of 404 (Not Found)
[00:04:52]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:04:52]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:05:02]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:05:02]             │      Wait timed out after 10014ms
[00:05:02]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:05:02]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:05:12]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:05:12]             │      Wait timed out after 10035ms
[00:05:13]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:05:13]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:05:23]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:05:23]             │      Wait timed out after 10034ms
[00:05:23]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:05:23]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:05:33]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:05:33]             │      Wait timed out after 10023ms
[00:05:34]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:05:34]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:05:44]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:05:44]             │      Wait timed out after 10021ms
[00:05:44]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:05:44]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:05:54]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:05:54]             │      Wait timed out after 10040ms
[00:05:55]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:05:55]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:06:05]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:06:05]             │      Wait timed out after 10034ms
[00:06:05]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:06:05]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:06:16]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:06:16]             │      Wait timed out after 10030ms
[00:06:16]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:06:16]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:06:26]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:06:26]             │      Wait timed out after 10027ms
[00:06:27]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:06:27]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:06:37]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:06:37]             │      Wait timed out after 10019ms
[00:06:37]             │ debg TestSubjects.find(removeSampleDataSetflights)
[00:06:37]             │ debg Find.findByCssSelector('[data-test-subj="removeSampleDataSetflights"]') with timeout=10000
[00:06:47]             │ debg --- retry.tryForTime error: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:06:47]             │      Wait timed out after 10044ms
[00:06:48]             │ info Taking screenshot "/dev/shm/workspace/parallel/3/kibana/x-pack/test/functional/screenshots/failure/Kibana overview _after all_ hook for _Overview view_.png"
[00:06:48]             │ info Current URL is: http://localhost:6131/app/home#/tutorial_directory/sampleData
[00:06:48]             │ info Saving page source to: /dev/shm/workspace/parallel/3/kibana/x-pack/test/functional/failure_debug/html/Kibana overview _after all_ hook for _Overview view_.html
[00:06:48]             └- ✖ fail: Kibana overview "after all" hook for "Overview view"
[00:06:48]             │      Error: retry.tryForTime timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
[00:06:48]             │ Wait timed out after 10044ms
[00:06:48]             │     at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:06:48]             │     at runMicrotasks (<anonymous>)
[00:06:48]             │     at processTicksAndRejections (internal/process/task_queues.js:93:5)
[00:06:48]             │       at onFailure (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry_for_success.ts:17:9)
[00:06:48]             │       at retryForSuccess (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry_for_success.ts:57:13)
[00:06:48]             │       at Retry.tryForTime (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry.ts:23:14)
[00:06:48]             │       at TestSubjects.waitForEnabled (/dev/shm/workspace/parallel/3/kibana/test/functional/services/common/test_subjects.ts:295:7)
[00:06:48]             │       at HomePage.removeSampleDataSet (/dev/shm/workspace/parallel/3/kibana/test/functional/page_objects/home_page.ts:54:7)
[00:06:48]             │       at Context.<anonymous> (test/accessibility/apps/kibana_overview.ts:26:7)
[00:06:48]             │       at Object.apply (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:06:48]             │ 
[00:06:48]             │

Stack Trace

Error: retry.tryForTime timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="removeSampleDataSetflights"])
Wait timed out after 10044ms
    at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at onFailure (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry_for_success.ts:57:13)
    at Retry.tryForTime (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry.ts:23:14)
    at TestSubjects.waitForEnabled (/dev/shm/workspace/parallel/3/kibana/test/functional/services/common/test_subjects.ts:295:7)
    at HomePage.removeSampleDataSet (/dev/shm/workspace/parallel/3/kibana/test/functional/page_objects/home_page.ts:54:7)
    at Context.<anonymous> (test/accessibility/apps/kibana_overview.ts:26:7)
    at Object.apply (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	178.4KB	179.9KB	+1.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dashboard`	308.2KB	308.4KB	+269.0B
`navigation`	19.3KB	20.3KB	+1.1KB
total			+1.3KB

History

💔 Build #106625 failed 7633d48
💛 Build #106306 was flaky 8327cac
💚 Build #106257 succeeded 412a67e
💔 Build #106196 failed d767369
💚 Build #105878 succeeded b33b29a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Added unsaved changes badge to dashboards. Removed (unsaved) from the dashboard title

Added unsaved changes badge to dashboards. Removed (unsaved) from the…

f2a37ae

… dashboard title

ThomThomson added release_note:enhancement Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.0.0 Project:TimeToVisualize v7.12.0 labels Feb 11, 2021

ThomThomson added 3 commits February 10, 2021 22:31

i18n fix

b33b29a

Made badge show only based on unsavedPanelState

4d066f2

Added toast on migration to hint to users where the unsaved badge is …

d767369

…coming from

ThomThomson marked this pull request as ready for review February 11, 2021 20:01

ThomThomson requested review from a team as code owners February 11, 2021 20:01

type fix

412a67e

ThomThomson force-pushed the feature/unsavedChangesBadge branch from 7a461dc to 412a67e Compare February 11, 2021 21:51

ryankeairns approved these changes Feb 11, 2021

View reviewed changes

src/plugins/navigation/public/top_nav_menu/top_nav_menu.tsx Outdated Show resolved Hide resolved

moved class, removed span

8327cac

clintandrewhall approved these changes Feb 12, 2021

View reviewed changes

ppisljar approved these changes Feb 15, 2021

View reviewed changes

kibanamachine and others added 2 commits February 15, 2021 10:06

Merge branch 'master' into feature/unsavedChangesBadge

7633d48

Remove unsaved tag from functional test

b4dc1c6

ThomThomson merged commit dc4e94e into elastic:master Feb 16, 2021

ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Feb 16, 2021

[Time to Visualize] Unsaved Changes Badge (elastic#91073)

dbf51c1

* Added unsaved changes badge to dashboards. Removed (unsaved) from the dashboard title

ThomThomson mentioned this pull request Feb 16, 2021

[7.x] [Time to Visualize] Unsaved Changes Badge (#91073) #91540

Merged

ThomThomson added a commit that referenced this pull request Feb 16, 2021

[Time to Visualize] Unsaved Changes Badge (#91073) (#91540)

f81cdc3

* Added unsaved changes badge to dashboards. Removed (unsaved) from the dashboard title

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Time to Visualize] Unsaved Changes Badge#91073

[Time to Visualize] Unsaved Changes Badge#91073
ThomThomson merged 8 commits intoelastic:masterfrom
ThomThomson:feature/unsavedChangesBadge

ThomThomson commented Feb 11, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Feb 11, 2021

Uh oh!

ryankeairns left a comment

Uh oh!

Uh oh!

clintandrewhall left a comment

Uh oh!

ppisljar left a comment

Uh oh!

ThomThomson commented Feb 15, 2021

Uh oh!

kibanamachine commented Feb 16, 2021

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ThomThomson commented Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Feb 11, 2021

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson commented Feb 15, 2021

Uh oh!

kibanamachine commented Feb 16, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ThomThomson commented Feb 11, 2021 •

edited

Loading