[Search Sessions] Secure access to session routes based on user permissions#90990
Merged
Dosant merged 7 commits intoelastic:masterfrom Feb 11, 2021
Merged
[Search Sessions] Secure access to session routes based on user permissions#90990Dosant merged 7 commits intoelastic:masterfrom
Dosant merged 7 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
lizozom
reviewed
Feb 11, 2021
| read: [], | ||
| }, | ||
| ui: ['storeSearchSession'], | ||
| api: ['store_search_session'], |
Contributor
There was a problem hiding this comment.
Any reason why one is camel case and one is snake case?
Contributor
Author
There was a problem hiding this comment.
I don't know why ui is camel, but the id of the privilege itself is lowercase, I decided to go with lowercase because the main id is lowercase 🤷♂️ . not sure if there is a convention
lizozom
approved these changes
Feb 11, 2021
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Awesome!
LGTM
Just note comment on casing
…ssion-api-auth # Conflicts: # x-pack/plugins/features/server/oss_features.ts
Contributor
Author
|
@elasticmachine merge upstream |
pgayvallet
approved these changes
Feb 11, 2021
…ssion-api-auth # Conflicts: # x-pack/test/api_integration/apis/search/session.ts
…a into dev/search-session-api-auth
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Feb 12, 2021
Dosant
added a commit
that referenced
this pull request
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Give access to session API routes only if the user has permissions to store search session granted by one of the apps
Checklist
For maintainers