[Search Sessions] batch trackId calls#90956
Merged
Dosant merged 9 commits intoelastic:masterfrom Feb 11, 2021
Merged
Conversation
This was referenced Feb 10, 2021
Closed
Dosant
commented
Feb 10, 2021
| const idMappings = Object.values(idMapping).map((value: any) => value.id); | ||
| expect(idMappings).to.contain(id1); | ||
| expect(idMappings).to.contain(id2); | ||
| await retry.waitForWithTimeout('searches persisted into session', 5000, async () => { |
Contributor
Author
There was a problem hiding this comment.
We anyway had a subtle race condition here before this pr, because we never awaited trackId inside session service. No time to track increase because of batching, so this test was failing more ofter
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
2 tasks
lizozom
approved these changes
Feb 11, 2021
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Tested and working fine.
I wonder if we should increase the debounce interval a little. Even on my local machine, a dashboard search session is still updated in a total of 3-4 calls to ES (which is still a huge improvement from 2-3 calls per search!)
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Feb 11, 2021
Dosant
added a commit
that referenced
this pull request
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Not sure if we need this, want to check if it helps with this noise
Opening
[Logs] Web Trafficdashboard audit logs locallyBefore
updating search-session~16-20 times in totalAfter
updating search-session~3 times in totalAfter the change
Checklist
Delete any items that are not applicable to this PR.
For maintainers