Skip to content

[Lens] Fix UI regression on toolbar buttons#90953

Merged
dej611 merged 2 commits intoelastic:masterfrom
dej611:fix/90407
Feb 11, 2021
Merged

[Lens] Fix UI regression on toolbar buttons#90953
dej611 merged 2 commits intoelastic:masterfrom
dej611:fix/90407

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Feb 10, 2021

Summary

Fixes #90407

This PR restores the button group UI which has changed since 7.10. The bug was a class typo when renaming the scss files, where the component didn't follow.

Before:

Screenshot 2021-02-10 at 15 27 47

After:

Screenshot 2021-02-10 at 15 27 32

@dej611 dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 Feature:Lens v7.12.0 labels Feb 10, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kibanaReact 119.4KB 119.4KB +9.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 added the release_note:skip Skip the PR/issue when compiling release notes label Feb 11, 2021
@dej611 dej611 marked this pull request as ready for review February 11, 2021 09:00
@dej611 dej611 requested a review from a team as a code owner February 11, 2021 09:00
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome, works fine. LGTM

Copy link
Copy Markdown
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dej611 dej611 changed the title [Lens] Fix UI regression on toolbar buttons [Lens] Restore UI regression on toolbar buttons Feb 11, 2021
@dej611 dej611 changed the title [Lens] Restore UI regression on toolbar buttons [Lens] Fix UI regression on toolbar buttons Feb 11, 2021
@dej611 dej611 merged commit 9f38e3a into elastic:master Feb 11, 2021
@dej611 dej611 deleted the fix/90407 branch February 11, 2021 11:38
dej611 added a commit to dej611/kibana that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Lens] Toolbar icons are not grouped

5 participants