Skip to content

Add saved object docs#90860

Merged
stacey-gammon merged 12 commits intoelastic:masterfrom
stacey-gammon:2021-02-04-saved-object-docs
Feb 11, 2021
Merged

Add saved object docs#90860
stacey-gammon merged 12 commits intoelastic:masterfrom
stacey-gammon:2021-02-04-saved-object-docs

Conversation

@stacey-gammon
Copy link
Copy Markdown

Add a key concepts section with high level info:
Screen Shot 2021-02-09 at 4 51 35 PM

Tutorial section with content taken from https://www.elastic.co/guide/en/kibana/current/kibana-platform-api.html#saved-objects-service
Screen Shot 2021-02-09 at 4 51 50 PM

@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Feb 9, 2021
Copy link
Copy Markdown
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs are great!


## References

In order to support import and export capabilities, Saved Objects need to explicitly list any references they contain to other Saved Objects.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

References also come into play for multi-space saved-objects. When sharing a saved-object to another space, all direct and transitive children must be shared as well, to prevent having a broken object graph.

Stacey Gammon and others added 8 commits February 10, 2021 10:20
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Copy link
Copy Markdown
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great, I wish we had these years ago.

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon added auto-backport Deprecated - use backport:version if exact versions are needed backport This PR is a backport of another PR labels Feb 11, 2021
@stacey-gammon stacey-gammon merged commit 9fca7a9 into elastic:master Feb 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2021
* iwp

* add docs on saved objects

* add saved object docs

* Update dev_docs/key_concepts/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* review updates

* remove this line, support being added

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Project:DevDocs","auto-backport","backport","docs","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"9fca7a9012f8d6944d40db1aee00e6adabef2c3c\",\"formattedMessage\":\"Add saved object docs (#90860)\",\"originalMessage\":\"Add saved object docs (#90860)\\n\\n* iwp\\r\\n\\r\\n* add docs on saved objects\\r\\n\\r\\n* add saved object docs\\r\\n\\r\\n* Update dev_docs/key_concepts/saved_objects.mdx\\r\\n\\r\\nCo-authored-by: Brandon Kobel <brandon.kobel@gmail.com>\\r\\n\\r\\n* Update dev_docs/tutorials/saved_objects.mdx\\r\\n\\r\\nCo-authored-by: Brandon Kobel <brandon.kobel@gmail.com>\\r\\n\\r\\n* Update dev_docs/tutorials/saved_objects.mdx\\r\\n\\r\\nCo-authored-by: Brandon Kobel <brandon.kobel@gmail.com>\\r\\n\\r\\n* Update dev_docs/tutorials/saved_objects.mdx\\r\\n\\r\\nCo-authored-by: Brandon Kobel <brandon.kobel@gmail.com>\\r\\n\\r\\n* Update dev_docs/tutorials/saved_objects.mdx\\r\\n\\r\\nCo-authored-by: Brandon Kobel <brandon.kobel@gmail.com>\\r\\n\\r\\n* Update dev_docs/tutorials/saved_objects.mdx\\r\\n\\r\\nCo-authored-by: Brandon Kobel <brandon.kobel@gmail.com>\\r\\n\\r\\n* Update dev_docs/tutorials/saved_objects.mdx\\r\\n\\r\\nCo-authored-by: Brandon Kobel <brandon.kobel@gmail.com>\\r\\n\\r\\n* review updates\\r\\n\\r\\n* remove this line, support being added\\r\\n\\r\\nCo-authored-by: Brandon Kobel <brandon.kobel@gmail.com>\",\"pullNumber\":90860,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] Add saved object docs (#90860)\". kibanamachine:backport/7.x/pr-90860 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1155ms"}
{"level":"info","message":"Adding assignees to #91152: stacey-gammon"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91152/assignees - 201 in 552ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91152/labels - 200 in 364ms"}
View pull request: https://github.com/elastic/kibana/pull/91152

stacey-gammon pushed a commit that referenced this pull request Feb 11, 2021
* iwp

* add docs on saved objects

* add saved object docs

* Update dev_docs/key_concepts/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* Update dev_docs/tutorials/saved_objects.mdx

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

* review updates

* remove this line, support being added

Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>

Co-authored-by: Stacey Gammon <gammon@elastic.co>
Co-authored-by: Brandon Kobel <brandon.kobel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed backport This PR is a backport of another PR DevDocs docs release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants