[Time to Visualize] Copy Panel to Dashboard by ThomThomson · Pull Request #90856 · elastic/kibana

ThomThomson · 2021-02-09T21:42:07Z

Summary

Adds the ability to copy a panel from one dashboard to another. On submit the application redirects to the destination dashboard in edit mode, and adds the new panel to the bottom. This change will not be saved to the dashboard until the user chooses to save it.

The panel is always appended, even when a panel with the same id exists already.

Note: This does not include the ability to automatically make the panel 'by value', this can be added in a followup if necessary. For now, By Value panels remain by value, and by reference panels remain by reference.

Edit: The copy has been enhanced to the following:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

…_util deps

…oDashboardAction

elasticmachine · 2021-02-11T03:28:08Z

Pinging @elastic/kibana-presentation (Team:Presentation)

ryankeairns · 2021-02-11T14:09:44Z

src/plugins/dashboard/public/application/_dashboard_app.scss

 }

+.dshCopyToParagraph {
+  max-width: 400px;


I still need to run this locally, but I've led you astray here. There is a maxWidth prop on EuiModal that can be used for this case.

Ah, it turns out this setting was actually missing from the core service I was using to show the modal. I've added the option and it works correctly

…reate dashboard. Shortened copy

…oDashboardAction

poffdeluxe

Lgtm! Code looks good and works as expected

src/plugins/dashboard/public/application/actions/copy_to_dashboard_modal.tsx

poffdeluxe · 2021-02-11T16:56:03Z

src/plugins/dashboard/public/application/actions/copy_to_dashboard_modal.tsx

+                      data-test-subj="add-to-new-dashboard-option"
+                      id="new-dashboard-option"
+                      name="dashboard-option"
+                      disabled={!dashboardId}


This is disabled because you cannot copy from an unsaved dashboard. Am I reading that right?

Close! You can't copy from an unsaved dashboard, to another unsaved dashboard. This is because the URLs are the same, it would just append a copy of the panel.

src/plugins/presentation_util/public/components/dashboard_picker.tsx

src/plugins/dashboard/public/application/actions/copy_to_dashboard_modal.tsx

…oDashboardAction

ryankeairns

Thanks for the edits, nice addition!

kibanamachine · 2021-02-11T22:14:46Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dashboard`	203	206	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	177.6KB	177.6KB	-24.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dashboard`	299.0KB	308.2KB	+9.2KB
`presentationUtil`	25.6KB	25.7KB	+162.0B
total			+9.4KB

History

💚 Build #106116 succeeded d18791e
💔 Build #106084 failed 5de7f4f
💚 Build #105862 succeeded 276b798
💛 Build #105778 was flaky a617c8d
💔 Build #105727 failed 178f42607a65e2d477bb4ae71fce4a9fc80ba199

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Added copy to dashboard action

ThomThomson added 4 commits February 5, 2021 16:13

started copy to dashboard action. Removed dashboard from presentation…

c5b5594

…_util deps

Merge branch 'master' of github.com:elastic/kibana into feature/copyT…

3161e9a

…oDashboardAction

Finished copy to dashboard modal. Temporary copy

b78b518

implemented functional tests for copy to dashboard feature

cf2abdc

ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.0.0 Project:TimeToVisualize v7.12.0 release_note:feature Makes this part of the condensed release notes labels Feb 9, 2021

ThomThomson added 2 commits February 10, 2021 10:54

Merge branch 'master' of github.com:elastic/kibana into feature/copyT…

60d483a

…oDashboardAction

Implemented more feature for failing functional tests

b89f6b5

ThomThomson force-pushed the feature/copyToDashboardAction branch from 8462b13 to 178f426 Compare February 10, 2021 19:11

type fix

a617c8d

ThomThomson force-pushed the feature/copyToDashboardAction branch from 178f426 to a617c8d Compare February 10, 2021 20:46

implement copy changes

276b798

ThomThomson marked this pull request as ready for review February 11, 2021 03:28

ThomThomson requested review from a team as code owners February 11, 2021 03:28

ryankeairns reviewed Feb 11, 2021

View reviewed changes

ThomThomson requested a review from a team as a code owner February 11, 2021 15:52

max width for modal. Removed duplicate modal in confirm overlay for c…

5de7f4f

…reate dashboard. Shortened copy

ThomThomson force-pushed the feature/copyToDashboardAction branch from b74961d to 5de7f4f Compare February 11, 2021 15:54

ThomThomson added 2 commits February 11, 2021 11:49

API Changes

d1cb404

Merge branch 'master' of github.com:elastic/kibana into feature/copyT…

d18791e

…oDashboardAction

poffdeluxe approved these changes Feb 11, 2021

View reviewed changes

ryankeairns reviewed Feb 11, 2021

View reviewed changes

src/plugins/dashboard/public/application/actions/copy_to_dashboard_modal.tsx Show resolved Hide resolved

pgayvallet approved these changes Feb 11, 2021

View reviewed changes

use spacer instead of class

9b9903e

Merge branch 'master' of github.com:elastic/kibana into feature/copyT…

e9ba7ad

…oDashboardAction

ryankeairns self-requested a review February 11, 2021 20:55

ryankeairns approved these changes Feb 11, 2021

View reviewed changes

ThomThomson merged commit 6e8622f into elastic:master Feb 11, 2021

ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Feb 11, 2021

[Time to Visualize] Copy Panel to Dashboard (elastic#90856)

b21c6db

* Added copy to dashboard action

ThomThomson mentioned this pull request Feb 11, 2021

[7.x] [Time to Visualize] Copy Panel to Dashboard (#90856) #91228

Merged

ThomThomson added a commit that referenced this pull request Feb 12, 2021

[Time to Visualize] Copy Panel to Dashboard (#90856) (#91228)

4396e45

* Added copy to dashboard action

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Time to Visualize] Copy Panel to Dashboard#90856

[Time to Visualize] Copy Panel to Dashboard#90856
ThomThomson merged 13 commits intoelastic:masterfrom
ThomThomson:feature/copyToDashboardAction

ThomThomson commented Feb 9, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Feb 11, 2021

Uh oh!

ryankeairns Feb 11, 2021

Uh oh!

ThomThomson Feb 11, 2021

Uh oh!

poffdeluxe left a comment

Uh oh!

Uh oh!

poffdeluxe Feb 11, 2021

Uh oh!

ThomThomson Feb 11, 2021

Uh oh!

Uh oh!

Uh oh!

ryankeairns left a comment

Uh oh!

kibanamachine commented Feb 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

ThomThomson commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Feb 11, 2021

Uh oh!

ryankeairns Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

ThomThomson Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

poffdeluxe Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

ThomThomson Feb 11, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 11, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ThomThomson commented Feb 9, 2021 •

edited

Loading