[uptime] unskip previously skipped functional tests#90702
Merged
rashmivkulkarni merged 15 commits intoelastic:masterfrom Feb 9, 2021
Merged
[uptime] unskip previously skipped functional tests#90702rashmivkulkarni merged 15 commits intoelastic:masterfrom
rashmivkulkarni merged 15 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
This test has passed in cloud flaky test runner suite as well. https://internal-ci.elastic.co/view/All/job/elastic+estf-cloud-kibana-flaky-test-runner/209/ |
LeeDr
approved these changes
Feb 9, 2021
LeeDr
left a comment
There was a problem hiding this comment.
LGTM - I saw the flaky test runner passed. I think other changes in this app must have also fixed these tests.
andrewvc
approved these changes
Feb 9, 2021
Contributor
andrewvc
left a comment
There was a problem hiding this comment.
LGTM. Thanks for doing this!
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Feb 9, 2021
* fixes elastic#74449 * unskipping uptime -functional test * unskipping location.ts script
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Feb 9, 2021
* fixes elastic#74449 * unskipping uptime -functional test * unskipping location.ts script
rashmivkulkarni
added a commit
that referenced
this pull request
Feb 10, 2021
rashmivkulkarni
added a commit
that referenced
this pull request
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why it was flaky before but now these uptime functional tests are passing now without any changes
Fixes #84992
Fixes: #85208