Skip to content

[test] Await retry.waitFor#90456

Merged
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:await-retry-waitfor
Feb 6, 2021
Merged

[test] Await retry.waitFor#90456
tylersmalley merged 1 commit intoelastic:masterfrom
tylersmalley:await-retry-waitfor

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Feb 5, 2021

Caused by #89942

@rudolf was seeing these failures which would result in passed tests, but a failed job: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/104171/execution/node/796/log/

02:20:07  Error: timed out waiting for Telemetry to disappear. -- last error: NoSuchSessionError: This driver instance does not have a valid session ID (did you call WebDriver.quit()?) and may no longer be used.
02:20:07      at /dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/webdriver.js:730:38
02:20:07      at Object.thenFinally [as finally] (/dev/shm/workspace/kibana/node_modules/selenium-webdriver/lib/promise.js:124:12)
02:20:07      at runMicrotasks (<anonymous>)
02:20:07      at processTicksAndRejections (internal/process/task_queues.js:93:5)
02:20:07      at /dev/shm/workspace/parallel/3/kibana/test/functional/services/remote/remote.ts:128:5
02:20:07      at /dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_test_runner/lib/lifecycle_phase.ts:65:11
02:20:07      at async Promise.all (index 4)
02:20:07      at LifecyclePhase.trigger (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_test_runner/lib/lifecycle_phase.ts:62:5)
02:20:07      at FunctionalTestRunner.close (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_test_runner/functional_test_runner.ts:161:5)
02:20:07      at FunctionalTestRunner._run (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_test_runner/functional_test_runner.ts:144:9)
02:20:07      at FunctionalTestRunner.run (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_test_runner/functional_test_runner.ts:45:12)
02:20:07      at runFtr (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_tests/lib/run_ftr.js:67:24)
02:20:07      at /dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_tests/tasks.js:98:9
02:20:07      at withProcRunner (/dev/shm/workspace/parallel/3/kibana/packages/kbn-dev-utils/target/proc_runner/with_proc_runner.js:24:9)
02:20:07      at runTests (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_tests/tasks.js:91:5)
02:20:07      at /dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_tests/cli/run_tests/cli.js:24:5
02:20:07      at runCli (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_tests/lib/run_cli.js:30:5)
02:20:07      at Object.runTestsCli (/dev/shm/workspace/parallel/3/kibana/packages/kbn-test/src/functional_tests/cli/run_tests/cli.js:22:3)
02:20:07      at onFailure (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry_for_truthy.ts:39:13)
02:20:07      at retryForSuccess (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry_for_success.ts:57:13)
02:20:07      at retryForTruthy (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry_for_truthy.ts:27:3)
02:20:07      at Retry.waitFor (/dev/shm/workspace/parallel/3/kibana/test/common/services/retry/retry.ts:60:7)

@tylersmalley
[test] Await retry.waitFor
b1e8e0b 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley mentioned this pull request Feb 5, 2021
Merged
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Feb 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 5, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley marked this pull request as ready for review February 5, 2021 18:36
@tylersmalley tylersmalley requested review from cuff-links and removed request for cuff-links February 5, 2021 18:36
@tylersmalley
Copy link
Copy Markdown
Member Author

tylersmalley commented Feb 5, 2021

@rudolf or @cuff-links, mind reviewing?

cuff-links
cuff-links approved these changes Feb 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@cuff-links cuff-links left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran these locally. Looks good to me.

@tylersmalley tylersmalley merged commit be725ca into elastic:master Feb 6, 2021
@tylersmalley tylersmalley mentioned this pull request Feb 6, 2021
Merged
tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Feb 6, 2021
@tylersmalley
[test] Await retry.waitFor (elastic#90456)
69d2661 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley added a commit that referenced this pull request Feb 6, 2021
@tylersmalley
[test] Await retry.waitFor (#90456) (#90541)
f7d50e5 
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 8, 2021
@gmmorris
Merge branch 'master' into task-manager/support-limited-concurrency
e3c8430 
* master: (55 commits)
  [APM-UI][E2E] use githubNotify step (elastic#90514)
  [APM] Export ProcessorEvent type (elastic#90540)
  [Lens] Retain column config (elastic#90048)
  [Data Table] Add unit tests (elastic#90173)
  Migrate most plugins to synchronous lifecycle (elastic#89562)
  skip flaky suite (elastic#90555)
  skip flaky suite (elastic#64473)
  [actions] improve email action doc (elastic#90020)
  [Fleet] Support Fleet server system indices (elastic#89372)
  skip flaky suite (elastic#90552)
  Bump immer dependencies (elastic#90267)
  Unrevert "Migrations v2: don't auto-create indices + FTR/esArchiver support (elastic#85778)" (elastic#89992)
  [Search Sessions] Use sync config (elastic#90138)
  chore(NA): add safe guard to remove bazelisk from yarn global at bootstrap (elastic#90538)
  [test] Await retry.waitFor (elastic#90456)
  chore(NA): integrate build buddy with our bazel setup and remote cache for ci (elastic#90116)
  Skip failing suite (elastic#90526)
  [Fleet] Fix incorrect conversion of string to numeric values in agent YAML (elastic#90371)
  [Docs] Update reporting troubleshooting for arm rhel/centos (elastic#90385)
  chore(NA): build bazel projects all at once in the distributable build process (elastic#90328)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cuff-links cuff-links cuff-links approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tylersmalley @kibanamachine @cuff-links