Skip to content

Accessibility test- unskipping a functional test (kibana_overview.ts)#90395

Merged
rashmivkulkarni merged 13 commits intoelastic:masterfrom
rashmivkulkarni:accessibility_kibana_overview
Feb 5, 2021
Merged

Accessibility test- unskipping a functional test (kibana_overview.ts)#90395
rashmivkulkarni merged 13 commits intoelastic:masterfrom
rashmivkulkarni:accessibility_kibana_overview

Conversation

@rashmivkulkarni
Copy link
Copy Markdown
Contributor

@rashmivkulkarni rashmivkulkarni commented Feb 5, 2021 •
edited
Loading

Fixes #82226

This test passed continuously 50 times in a row locally.

@rashmivkulkarni rashmivkulkarni self-assigned this Feb 5, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 5, 2021

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 5, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

myasonik
myasonik approved these changes Feb 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I mean, I'm happy to merge this if it passes but it does seem weird that it was flaky but now it isn't with no changes...

@mistic how concerned should we be about that?

@rashmivkulkarni
Copy link
Copy Markdown
Contributor Author

rashmivkulkarni commented Feb 5, 2021

Flaky test runner build: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1247/

bhavyarm
bhavyarm approved these changes Feb 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashmivkulkarni rashmivkulkarni merged commit 3ba3131 into elastic:master Feb 5, 2021
This was referenced Feb 5, 2021
Closed
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Feb 5, 2021
@rashmivkulkarni
Accessibility test- unskipping a functional test (kibana_overview.ts) (…
646e731 
…elastic#90395)

* fixes elastic#74449

* unskipping accessibility test
rashmivkulkarni added a commit that referenced this pull request Feb 5, 2021
@rashmivkulkarni
Accessibility test- unskipping a functional test (kibana_overview.ts) (…
517e46e 
…#90395) (#90493)

* fixes #74449

* unskipping accessibility test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

+1 more reviewer

@myasonik myasonik myasonik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rashmivkulkarni rashmivkulkarni

Labels

automation Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing test: X-Pack Accessibility Tests.x-pack/test/accessibility/apps/kibana_overview·ts - Kibana overview "after all" hook for "Overview view"

5 participants

@rashmivkulkarni @elasticmachine @kibanamachine @myasonik @bhavyarm