Fix Visualize Link Redirecting to Dashboard Linked Visualization#90243
Merged
ThomThomson merged 4 commits intoelastic:masterfrom Feb 5, 2021
Merged
Fix Visualize Link Redirecting to Dashboard Linked Visualization#90243ThomThomson merged 4 commits intoelastic:masterfrom
ThomThomson merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
wylieconlon
approved these changes
Feb 4, 2021
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
Tested that this only affects the flow you're talking about, but does not affect the flow if you started from Visualize. LGTM
| !urlToSave.includes(`${VisualizeConstants.EDIT_PATH}/`) && | ||
| this.isLinkedToOriginatingApp?.() | ||
| ) { | ||
| return core.http.basePath.prepend('/app/visualize'); |
Contributor
There was a problem hiding this comment.
I'm surprised this isn't pulled out into a separate constant of some kind, in case it ever changes or becomes configurable
Contributor
Author
There was a problem hiding this comment.
I was surprised about this too - though it was only used once before this PR so maybe this is the right time to pull it out. Will add it to the constants.
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Feb 5, 2021
ThomThomson
added a commit
that referenced
this pull request
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FIxes #90221 (option 2) by using
onBeforeNavLinkSavedto return the nav link only when the state transfer service is not linked to an originating app. Otherwise it will return the visualize listing page.Checklist
Delete any items that are not applicable to this PR.
For maintainers