[Saved Objects] Allow exporting and importing hidden types#90178
Merged
Bamieh merged 22 commits intoelastic:masterfrom Feb 14, 2021
Merged
[Saved Objects] Allow exporting and importing hidden types#90178Bamieh merged 22 commits intoelastic:masterfrom
Bamieh merged 22 commits intoelastic:masterfrom
Conversation
…/export_import_hidden_types
Bamieh
commented
Feb 3, 2021
Bamieh
commented
Feb 3, 2021
Bamieh
commented
Feb 3, 2021
Bamieh
commented
Feb 3, 2021
…/export_import_hidden_types
…/export_import_hidden_types
Bamieh
commented
Feb 8, 2021
Contributor
⏳ Build in-progress, with failures
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
@elasticmachine merge upstream |
pgayvallet
reviewed
Feb 9, 2021
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
Implementation looking good. Just need some plugin_functional FTR tests and it will be perfect!
Comment on lines
+37
to
+42
| const includedHiddenTypes = chain(typesToInclude) | ||
| .uniq() | ||
| .filter( | ||
| (type) => typeRegistry.isHidden(type) && typeRegistry.isImportableAndExportable(type) | ||
| ) | ||
| .value(); |
Contributor
There was a problem hiding this comment.
NIT: block used at least in 3 routes, may want to factorize.
…/export_import_hidden_types
…/export_import_hidden_types
pgayvallet
approved these changes
Feb 12, 2021
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
I would add a FTR test to ensure that exportable+hidden types are visible in the SO management UI
Apart from that, LGTM!
…/export_import_hidden_types
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Bamieh
added a commit
that referenced
this pull request
Feb 15, 2021
) (#91351) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82027