Timelion reads raw field list from saved object, should grab from index pattern api#89988
Merged
alexwizp merged 2 commits intoelastic:masterfrom Feb 3, 2021
Merged
Timelion reads raw field list from saved object, should grab from index pattern api#89988alexwizp merged 2 commits intoelastic:masterfrom
alexwizp merged 2 commits intoelastic:masterfrom
Conversation
…ex pattern api Closes: elastic#84387
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
VladLasitsa
suggested changes
Feb 2, 2021
src/plugins/vis_type_timelion/public/helpers/arg_value_suggestions.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Feb 3, 2021
…ex pattern api (elastic#89988) * Timelion reads raw field list from saved object, should grab from index pattern api Closes: elastic#84387 * fix PR comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #84387
Summary
Timelionreads the index pattern field list from the index pattern saved object. Instead use the index pattern service to load the index pattern.Dev/Testing notes
savedObjectsClientwas changed toindexPatternsservice in following places:arg_value_suggestions.tsTo test suggestions please you can use the following timeline expressions.
Index suggestions:
Fields suggestions:
series_functions/es/index.js
Scripted fields suggestions: