[Metrics UI] Fix alert preview accuracy with new Notify settings#89939
Merged
Zacqary merged 19 commits intoelastic:masterfrom Feb 11, 2021
Merged
[Metrics UI] Fix alert preview accuracy with new Notify settings#89939Zacqary merged 19 commits intoelastic:masterfrom
Zacqary merged 19 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Contributor
Author
|
@elasticmachine merge upstream |
2 tasks
Contributor
Author
|
@elasticmachine merge upstream |
YulNaumenko
approved these changes
Feb 3, 2021
Contributor
YulNaumenko
left a comment
There was a problem hiding this comment.
Code LGTM. Would be nice to have a unit test that AlertTypeParamsExpression is working with the new option as expected.
Contributor
Author
|
@elasticmachine merge upstream |
…into 88909-preview-notify-fix
Contributor
|
jenkins test this |
Contributor
Author
|
@elasticmachine merge upstream |
…ify-fix # Conflicts: # x-pack/plugins/infra/server/lib/alerting/inventory_metric_threshold/preview_inventory_metric_threshold_alert.ts # x-pack/plugins/infra/server/lib/alerting/metric_threshold/preview_metric_threshold_alert.ts
…into 88909-preview-notify-fix
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Firefox XPack UI Functional Tests.x-pack/test/functional/apps/grok_debugger/grok_debugger·js.logstash grok debugger app "before all" hook in "grok debugger app"Standard OutStack TraceMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
neptunian
approved these changes
Feb 11, 2021
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Feb 11, 2021
…stic#89939) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #88909
The Alert Preview component will now correctly calculate notifications based on the
Notifysetting.Checklist
Delete any items that are not applicable to this PR.