Fix documentMigrator for snapshot releases#89936
Merged
rudolf merged 1 commit intoelastic:masterfrom Feb 2, 2021
Merged
Conversation
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Feb 2, 2021
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Feb 8, 2021
rudolf
added a commit
that referenced
this pull request
Feb 9, 2021
* Enable v2 so migrations, disable in FTR tests (#89297) * Enable v2 so migrations, disable in FTR tests * Disable v2 migrations for ui_settings integration tests * Disable v2 migrations for reporting without serucity api integration test # Conflicts: # test/common/config.js * migrations v2: fix snapshot builds (#89541) * migrations v2: fix snapshot builds * Revert "Fix sharing saved objects phase 2 CI (#89056)" This reverts commit 8263d47. * Fix documentMigrator for snapshot releases (#89936) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in my fix in #89541 😓 I only tested #89541 with a new ES cluster, not with a
.kibanaindex with existing docs. This time I tested it with the sample data and a dump of observability's development cluster.Checklist
Delete any items that are not applicable to this PR.
For maintainers