[Data Table] Use shared CSV export mechanism#89702
Merged
sulemanof merged 9 commits intoelastic:masterfrom Feb 2, 2021
Merged
Conversation
added 9 commits
January 29, 2021 13:42
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
stratoula
approved these changes
Feb 1, 2021
Contributor
stratoula
left a comment
There was a problem hiding this comment.
I have tested a lot locally, it seems to work fine :) Code LGTM. Looking forward for the unit tests 🎉
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
dej611
approved these changes
Feb 1, 2021
Contributor
dej611
left a comment
There was a problem hiding this comment.
👍 Tested on Chrome and Safari
alexwizp
approved these changes
Feb 2, 2021
sulemanof
pushed a commit
to sulemanof/kibana
that referenced
this pull request
Feb 2, 2021
* Move formatting columns into response handler * Use shared csv export * Cleanup files * Fix type * Fix translation * Filter out non-dimension values
sulemanof
pushed a commit
that referenced
this pull request
Feb 2, 2021
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Feb 2, 2021
…-ml-jobs * 'master' of github.com:elastic/kibana: (254 commits) [Security Solution] [Detections] Remove allow_no_indices to prevent error being thrown in response of field capabilities (elastic#89927) Skip test for cloud (elastic#89450) [Fleet] Fix duplicate data streams being shown in UI (elastic#89812) Bump package dependencies (elastic#90034) [App Search] DRY helper for encoding/decoding routes that can have special characters in params (elastic#89811) TypeScript project references for Observability plugin (elastic#89320) [SearchSource] Combine sort and parent fields when serializing (elastic#89808) Made imports static (elastic#89935) [ml] migrate file_data_visualizer/import route to file_upload plugin (elastic#89640) [Discover] Adapt default column behavior (elastic#89826) Round start and end values (elastic#89030) Rename getProxyAgents to getCustomAgents (elastic#89813) [Form lib] UseField `onError` listener (elastic#89895) [APM] use latency sum instead of avg for impact (elastic#89990) migrate more core-owned plugins to tsproject ref (elastic#89975) [Logs UI] Load <LogStream> entries via async searches (elastic#86899) [APM] Abort browser requests when appropriate (elastic#89557) [Alerting] Allow user to select existing connector of same type when fixing broken connector (elastic#89062) [Data Table] Use shared CSV export mechanism (elastic#89702) chore(NA): improve logic check when installing Bazel tools (elastic#89634) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #84759
This PR replaces custom CSV export function with a common mechanism :
datatableToCSVfromdataplugin anddownloadFileAsfromsharedplugin.To switch the usage on the common mechanism, the table
visDatashape was changed.useFormattedColumnsAndRowseffect where removed fromTableVisBasicand the logic was moved intocreateFormattedTablefunction - this creates the necessary shape both for data rendering and creating a CSV.Other changes are mostly caused by data shape changes.
Unit test cases will be added in a follow up PR #89719