[XY Plugin] Add unit tests#89582
Merged
stratoula merged 15 commits intoelastic:masterfrom Feb 11, 2021
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
nickofthyme
approved these changes
Feb 1, 2021
Contributor
nickofthyme
left a comment
There was a problem hiding this comment.
The code changes look great to me! Thanks for handling this. I left a few minor comments but not blocking.
src/plugins/vis_type_xy/public/components/detailed_tooltip.test.tsx
Outdated
Show resolved
Hide resolved
...lugins/vis_type_xy/public/editor/components/options/point_series/point_series.tests.mocks.ts
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
alexwizp
reviewed
Feb 11, 2021
src/plugins/vis_type_xy/public/components/detailed_tooltip.mock.ts
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Feb 11, 2021
src/plugins/vis_type_xy/public/editor/components/common/truncate_labels.test.tsx
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Feb 11, 2021
src/plugins/vis_type_xy/public/components/detailed_tooltip.test.tsx
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Feb 11, 2021
src/plugins/vis_type_xy/public/editor/components/options/point_series/point_series.test.tsx
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Feb 11, 2021
src/plugins/vis_type_xy/public/editor/components/options/point_series/point_series.test.tsx
Outdated
Show resolved
Hide resolved
alexwizp
reviewed
Feb 11, 2021
src/plugins/vis_type_xy/public/editor/components/common/truncate_labels.test.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
I will merge it as I have two approvals and is a unit tests related PR |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Feb 11, 2021
* [XY Plugin] Add unit tests * More unit tests * Address PR comments * Update license * Resolve PR comments * A nice improvement * Apply new type everywhere * Cleaning up Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
Feb 15, 2021
* [XY Plugin] Add unit tests * More unit tests * Address PR comments * Update license * Resolve PR comments * A nice improvement * Apply new type everywhere * Cleaning up Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #82498. This PR adds unit tests on the xy plugin.
Checklist