decorateSnapshotUi: get file from stacktrace#88950
Merged
dgieselaar merged 5 commits intoelastic:masterfrom Jan 21, 2021
Merged
decorateSnapshotUi: get file from stacktrace#88950dgieselaar merged 5 commits intoelastic:masterfrom
dgieselaar merged 5 commits intoelastic:masterfrom
Conversation
Instead of using test.file, use callsites() to get the test file from the stack trace. test.file is not always reliable.
spalger
approved these changes
Jan 21, 2021
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Jan 21, 2021
dgieselaar
added a commit
that referenced
this pull request
Jan 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using test.file, use callsites() to get the test file from the stack trace. test.file is not always reliable.