Make xpack.actions.rejectUnauthorized setting work#88690
Merged
mikecote merged 15 commits intoelastic:masterfrom Jan 28, 2021
Merged
Make xpack.actions.rejectUnauthorized setting work#88690mikecote merged 15 commits intoelastic:masterfrom
xpack.actions.rejectUnauthorized setting work#88690mikecote merged 15 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
approved these changes
Jan 20, 2021
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
LGTM
Seems like we could build a function test for this - create a new https server with a newly created self-signed cert (with a loooong lifetime), that just has one endpoint that we can test with webhook. Then execute the webhook, with and without the rejectUnauthorized setting - should get one to work and the other to fail. Obviously set it up to use the proxy we're testing with, in security_and_spaces . :-)
Contributor
Author
|
@pmuellr I went ahead and added a functional test in this commit (af638a3). I made it re-use the dev certs so it's one less thing to expire 🙂 I added it to the |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
…ana into actions/reject-unauthorized
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jan 28, 2021
* Remove ActionsConfigType due to being a duplicate * Fix rejectUnauthorized not being configured * Move proxySettings to configurationUtilities * Fix isAxiosError check to code * Add functional test * Remove comment * Close webhook server Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jan 28, 2021
* Remove ActionsConfigType due to being a duplicate * Fix rejectUnauthorized not being configured * Move proxySettings to configurationUtilities * Fix isAxiosError check to code * Add functional test * Remove comment * Close webhook server Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mikecote
added a commit
that referenced
this pull request
Jan 29, 2021
* Remove ActionsConfigType due to being a duplicate * Fix rejectUnauthorized not being configured * Move proxySettings to configurationUtilities * Fix isAxiosError check to code * Add functional test * Remove comment * Close webhook server Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
mikecote
added a commit
that referenced
this pull request
Jan 29, 2021
* Remove ActionsConfigType due to being a duplicate * Fix rejectUnauthorized not being configured * Move proxySettings to configurationUtilities * Fix isAxiosError check to code * Add functional test * Remove comment * Close webhook server Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #87047
In this PR, I'm doing a few changes to fix the problem. The general purpose of each commit is as follows:
ActionsConfigTypebecause it is a duplicate / subset ofActionsConfigthat wasn't needed. This allowed me to add more functionality to theconfigurationUtilitiesin following commits.configurationUtilitiesdown to thegetProxyAgentsfunction from every possible path. TheconfigurationUtilitieshas a new functionisRejectUnauthorizedCertificatesEnabled.proxySettingswas happening at the same places thatconfigurationUtilitieswas, I moved the access toproxySettingstoconfigurationUtilities.error.isAxiosErrordidn't always work (ex: when it mentions missing kbn-xsrf header) so I changed it toerror.code.