[SavedObjects] Allow migrations to be a function#88594
Merged
Bamieh merged 10 commits intoelastic:masterfrom Jan 19, 2021
Merged
[SavedObjects] Allow migrations to be a function#88594Bamieh merged 10 commits intoelastic:masterfrom
Bamieh merged 10 commits intoelastic:masterfrom
Conversation
rudolf
reviewed
Jan 18, 2021
Contributor
rudolf
left a comment
There was a problem hiding this comment.
Left some small nits, but overall looks good
Co-authored-by: Rudolf Meijering <skaapgif@gmail.com>
…bana into migrations/support_embeddables
rudolf
approved these changes
Jan 19, 2021
pgayvallet
reviewed
Jan 19, 2021
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
Overall, looking good.
Just got a question regarding the KibanaMigrator. migrateDocument call to documentMigrator.prepareMigrations
src/core/server/saved_objects/migrations/core/document_migrator.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 19, 2021
Fixed merge conflicts from elastic#88594.
Bamieh
added a commit
that referenced
this pull request
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84907
Allows Savedobject
migrationsproperty to be a function.Key changes:
savedObjectType.migrationsproperty can now be a function or an object.This will help support 'augmenting' the migration objects by other external plugins without requiring to manually add each version to the migration to check if those external plugins (like embeddables) need to migrate any sub-documents.
Code Example