[APM] Consistent terminology for latency and throughput#88452
Merged
sorenlouv merged 6 commits intoelastic:masterfrom Jan 15, 2021
Merged
[APM] Consistent terminology for latency and throughput#88452sorenlouv merged 6 commits intoelastic:masterfrom
sorenlouv merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
formgeist
reviewed
Jan 15, 2021
Contributor
formgeist
left a comment
There was a problem hiding this comment.
Looks good - I've made some suggestions for improvements on the new copy.
x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/TraceOverview/TraceList.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/app/transaction_overview/TransactionList/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/charts/transaction_charts/ml_header.tsx
Outdated
Show resolved
Hide resolved
…rts.ts Co-authored-by: Casper Hübertz <casper@formgeist.com>
formgeist
approved these changes
Jan 15, 2021
Contributor
formgeist
left a comment
There was a problem hiding this comment.
Approving just so I'm not blocking a merge
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
This was referenced Jan 15, 2021
sorenlouv
added a commit
to sorenlouv/kibana
that referenced
this pull request
Jan 15, 2021
Co-authored-by: Casper Hübertz <casper@formgeist.com>
sorenlouv
added a commit
that referenced
this pull request
Jan 17, 2021
… (#88503) Co-authored-by: Casper Hübertz <casper@formgeist.com> Co-authored-by: Casper Hübertz <casper@formgeist.com>
sorenlouv
added a commit
that referenced
this pull request
Jan 17, 2021
#88502) Co-authored-by: Casper Hübertz <casper@formgeist.com> Co-authored-by: Casper Hübertz <casper@formgeist.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 18, 2021
* master: (33 commits) [Security Solution][Case] Fix patch cases integration test with alerts (elastic#88311) [Security Solutions][Detection Engine] Removes duplicate API calls (elastic#88420) Fix log msg (elastic#88370) [Test] Add tag cloud visualization to dashboard in functional test for reporting (elastic#87600) removing kibana-core-ui from codeowners (elastic#88111) [Alerting] Migrate Event Log plugin to TS project references (elastic#81557) [Maps] fix zooming while drawing shape filter logs errors in console (elastic#88413) Porting fixes 1 (elastic#88477) [APM] Explicitly set environment for cross-service links (elastic#87481) chore(NA): remove mocha junit ci integrations (elastic#88129) [APM] Only display relevant sections for rum agent in service overview (elastic#88410) [Enterprise Search] Automatically mock shared logic files (elastic#88494) [APM] Disable Create custom link button on Transaction details page for read-only users [Docs] clean-up vega map reference documenation (elastic#88487) [Security Solution] Fix Timeline event details layout (elastic#88377) Change DELETE to POST for _bulk_delete to avoid incompatibility issues (elastic#87914) [Monitoring] Change cloud messaging on no data page (elastic#88375) [Uptime] clear ping state when PingList component in unmounted (elastic#88321) [APM] Consistent terminology for latency and throughput (elastic#88452) fix copy (elastic#88481) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #87483
I noticed we still were using "Req. per min" on the service map, and a couple of other inconsistencies in terminology. I think we agreed to only fix it for Service overview but it seemed like a low-hanging fruit that will make the experience more consistent.