I'm a bit confused with the flow here: is the goal to ensure just that the all dashboard selectors exist, without actually adding the Lens visualization to the dashboard?

as part of #83140, a new selector was added to the visualize save modal to allow users to add by value directly to a dashboard from visualize. That also means that in order to save it to the library, the user needs to select the add to library option on the dashboard selector.

What I've added here is a default path that says 'if the dashboard selection section exists, and we haven't been asked to add it directly to a dashboard, select the add to library option. This prevents a number of test failures - and you can see a similar implementation in the Visualize page.

What I've added here is a default path that says 'if the dashboard selection section exists, and we haven't been asked to add it directly to a dashboard, select the add to library option. This prevents a number of test failures - and you can see a similar implementation in the Visualize page.

nit: It might be helpful to extract this logic into another helper function that could be pulled into the lens & SO tagging functional tests. It feels like the type of implementation detail that other apps shouldn't necessarily need to concern themselves with when writing tests.

e.g. something like this could potentially be used everywhere:

await saveToNewDashboard();
await saveToExistingDashboard('my-dashboard-id');
await saveToLibrary();

🎉

Just curious, is the plan to enable this in 7.12 and then delete references to it in 7.13? Or are you also planning for a cleanup for 7.12?

That's still up in the air - because removing the ability to turn the feature off could constitute a breaking change. Right now the consensus seems to be removing references to it in 8.0.0

We'll craft a plan to at least deprecate with a warning in 8.0 for removal in a follow-on minor, if not remove outright. It kind of depends on feedback from the field.

What I've added here is a default path that says 'if the dashboard selection section exists, and we haven't been asked to add it directly to a dashboard, select the add to library option. This prevents a number of test failures - and you can see a similar implementation in the Visualize page.

nit: It might be helpful to extract this logic into another helper function that could be pulled into the lens & SO tagging functional tests. It feels like the type of implementation detail that other apps shouldn't necessarily need to concern themselves with when writing tests.

e.g. something like this could potentially be used everywhere:

await saveToNewDashboard();
await saveToExistingDashboard('my-dashboard-id');
await saveToLibrary();