Skip to content

[Monitoring] Convert Elasticsearch-related server files that read from _source to typescript#88212

Merged
chrisronline merged 8 commits intoelastic:masterfrom
chrisronline:monitoring/ecs_es
Jan 20, 2021
Merged

[Monitoring] Convert Elasticsearch-related server files that read from _source to typescript#88212
chrisronline merged 8 commits intoelastic:masterfrom
chrisronline:monitoring/ecs_es

Conversation

@chrisronline
Copy link
Copy Markdown
Contributor

@chrisronline chrisronline commented Jan 13, 2021 •
edited
Loading

Relates to #84370

This PR updates a couple source files used for Elasticsearch monitoring that read from source to using Typescript. This is an attempt to identify all fields read from source to help with #73864

This one is the biggest and some of the fields added to the type definition were sourced directly from UI files (such as https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/public/directives/elasticsearch/ml_job_listing/index.js#L62). I don't have a ton of certainty this is a fool-proof method, but I'm hoping we can find any missing items either through this PR, or when we get the final PR set up on the beats side (which will be easier to test because that PR will cause Metricbeat to only index the fields we told them to)

@chrisronline chrisronline changed the title [Monitoring] Convert Logstash-related server files that read from _source to typescript [Monitoring] Convert Elasticsearch-related server files that read from _source to typescript Jan 13, 2021
@chrisronline chrisronline mentioned this pull request Jan 18, 2021
Closed
5 tasks
@chrisronline chrisronline marked this pull request as ready for review January 19, 2021 15:28
@chrisronline chrisronline requested a review from a team January 19, 2021 15:28
@chrisronline chrisronline self-assigned this Jan 19, 2021
@chrisronline chrisronline added 8.0.0 release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.12.0 labels Jan 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 19, 2021

Pinging @elastic/stack-monitoring (Team:Monitoring)

igoristic
igoristic approved these changes Jan 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 20, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit c9002a2 into elastic:master Jan 20, 2021
@chrisronline chrisronline mentioned this pull request Jan 20, 2021
Merged
@chrisronline chrisronline deleted the monitoring/ecs_es branch January 20, 2021 18:49
chrisronline added a commit that referenced this pull request Jan 20, 2021
@chrisronline
[Monitoring] Convert Elasticsearch-related server files that read fro…
b0a5d57 
…m _source to typescript (#88212) (#88892)

* A good chunk of server-side ES changes

* CCR files

* More areas where we just pass down the source to the client

* Some more

* Fix tests

* Fix tests and types
@chrisronline chrisronline mentioned this pull request Mar 1, 2021
Closed
@chrisronline chrisronline mentioned this pull request Apr 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igoristic igoristic igoristic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chrisronline chrisronline

Labels

release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisronline @elasticmachine @kibanamachine @igoristic